Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-core): set nextconfigoutput correctly #63848

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 28, 2024

What

PR updates route's template injection correctly sets nextConfigOutput.

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Mar 28, 2024
Copy link
Contributor Author

kwonoj commented Mar 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kwonoj and the rest of your teammates on Graphite Graphite

@kwonoj kwonoj marked this pull request as ready for review March 28, 2024 23:26
@kwonoj kwonoj requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 28, 2024 23:26
@ijjk
Copy link
Member

ijjk commented Mar 28, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Mar 28, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
buildDuration 14s 14.1s N/A
buildDurationCached 8.7s 6.6s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 387ms 397ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 523 B N/A
Overall change 542 B 542 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
middleware-b..fest.js gzip 627 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 944 kB 944 kB
build cache
vercel/next.js canary vercel/next.js 03-28-feat_next-core_set_nextconfigoutput_correctly Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: c1e45c3

@kwonoj kwonoj force-pushed the 03-28-feat_next-core_set_nextconfigoutput_correctly branch 2 times, most recently from 1474ca8 to 70acbac Compare March 28, 2024 23:42
@kwonoj kwonoj force-pushed the 03-28-feat_next-core_set_nextconfigoutput_correctly branch from 70acbac to c1e45c3 Compare March 29, 2024 00:16
@kwonoj kwonoj merged commit b90dcdd into canary Mar 29, 2024
72 of 77 checks passed
@kwonoj kwonoj deleted the 03-28-feat_next-core_set_nextconfigoutput_correctly branch March 29, 2024 00:35
Copy link
Contributor Author

kwonoj commented Mar 29, 2024

Merge activity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants