Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test opentelemetry regressions #63944

Closed
wants to merge 2 commits into from
Closed

Conversation

dvoytenko
Copy link
Member

No description provided.

@ijjk
Copy link
Member

ijjk commented Apr 1, 2024

Failing test suites

Commit: e8e5bea

TURBOPACK=1 pnpm test test/integration/custom-error/test/index.test.js (turbopack)

  • Custom _error > development mode 2 > should not warn with /_error and /404
Expand output

● Custom _error › development mode 2 › should not warn with /_error and /404

expect(received).toContain(expected) // indexOf

Expected substring: "not found..."
Received string:    "<!DOCTYPE html><html><head><style data-next-hide-fouc=\"true\">body{display:none}</style><noscript data-next-hide-fouc=\"true\"><style>body{display:block}</style></noscript><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__5816a7._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/2c7be_react_22c55a._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_cjs_react-dom_development_c0b264.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_55c180._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/08b5e__pnpm_762be9._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_73d13f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_2ea996._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_37a473._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__5ccc71._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/2c7be_react_3cd7ff._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_7bf3f3._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_61282f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_f1aa5f._.js\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"><h3>Custom error!!</h3><p>An error 404 occurred on server</p></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":404}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"gip\":true,\"scriptLoader\":[]}</script></body></html>"

  69 |       const html = await renderViaHTTP(appPort, '/404')
  70 |       await fs.remove(page404)
> 71 |       expect(html).toContain('not found...')
     |                    ^
  72 |       expect(stderr).not.toMatch(customErrNo404Match)
  73 |     })
  74 |

  at Object.toContain (integration/custom-error/test/index.test.js:71:20)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 1, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary dvoytenko/next.js test-otel Change
buildDuration 13.7s 13.9s ⚠️ +179ms
buildDurationCached 8.5s 6.1s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +664 B
nextStartRea..uration (ms) 405ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js canary dvoytenko/next.js test-otel Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dvoytenko/next.js test-otel Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dvoytenko/next.js test-otel Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary dvoytenko/next.js test-otel Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary dvoytenko/next.js test-otel Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary dvoytenko/next.js test-otel Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary dvoytenko/next.js test-otel Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary dvoytenko/next.js test-otel Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 945 kB 945 kB
build cache
vercel/next.js canary dvoytenko/next.js test-otel Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 107 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: e8e5bea

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. type: next labels Apr 1, 2024
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we good to close this one now that #64085 has landed?

@dvoytenko dvoytenko closed this Apr 8, 2024
@dvoytenko dvoytenko deleted the test-otel branch April 8, 2024 18:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants