Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine necessary file for edge route in size calculation #65053

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 25, 2024

Just including page.js in the size calculation isn't enough since it may require other chunks.

In a Webpack world we'd use the Webpack stats instead for accurate calculations without having to read from the filesystem. Turbopack doesn't have these available so we just read every file listed in the the files entry for that specific route in the middleware manifest.

I know not enough about all these manifest to be able to generalize this so for now this only works for the edge-ssr calculation which regressed in #64798 but wasn't caught since the significant bundle increase was in a different chunk.

Before:
Screenshot 2024-04-26 at 17 41 40
-- #64798 (comment)

After:
Screenshot 2024-04-26 at 17 41 09
-- #65053 (comment)

Closes NEXT-3228

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Apr 25, 2024
@ijjk
Copy link
Member

ijjk commented Apr 25, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Apr 25, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
buildDuration 16.8s 15.3s N/A
buildDurationCached 8.5s 8.1s N/A
nodeModulesSize 359 MB 359 MB
nextStartRea..uration (ms) 427ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
139-HASH.js gzip 31.8 kB 31.8 kB N/A
2478adb-HASH.js gzip 53.5 kB 53.5 kB N/A
4967-HASH.js gzip 5.1 kB 5.1 kB N/A
6701.HASH.js gzip 168 B 168 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 229 B 225 B N/A
main-HASH.js gzip 31.6 kB 31.6 kB N/A
webpack-HASH.js gzip 1.65 kB 1.64 kB N/A
Overall change 45.3 kB 45.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
_app-HASH.js gzip 194 B 193 B N/A
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 510 B 510 B
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 2.51 kB 2.52 kB N/A
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 365 B 362 B N/A
hooks-HASH.js gzip 391 B 390 B N/A
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.69 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 393 B 395 B N/A
withRouter-HASH.js gzip 323 B 323 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.73 kB 1.73 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
index.html gzip 528 B 528 B
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
edge-ssr.js gzip 94.6 kB 94.7 kB N/A
page.js gzip 182 kB 182 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
middleware-b..fest.js gzip 623 B 623 B
middleware-r..fest.js gzip 155 B 154 B N/A
middleware.js gzip 27.9 kB 27.9 kB
edge-runtime..pack.js gzip 839 B 839 B
Overall change 29.4 kB 29.4 kB
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.4 kB 98.4 kB
app-page-tur..prod.js gzip 99.9 kB 99.9 kB
app-page-tur..prod.js gzip 94.2 kB 94.2 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93 kB 93 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.4 kB 21.4 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.4 kB 21.4 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/edge-route-size-comparison Change
0.pack gzip 1.61 MB 1.61 MB ⚠️ +2.46 kB
index.pack gzip 113 kB 113 kB ⚠️ +218 B
Overall change 1.72 MB 1.73 MB ⚠️ +2.68 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 9d5d317

@eps1lon eps1lon force-pushed the sebbie/edge-route-size-comparison branch from 7eb04f8 to f3bb0ab Compare April 26, 2024 15:07
@eps1lon eps1lon force-pushed the sebbie/edge-route-size-comparison branch from f3bb0ab to 6449c8d Compare April 26, 2024 15:21
@eps1lon eps1lon marked this pull request as ready for review April 26, 2024 15:43
@eps1lon eps1lon requested review from ismaelrumzan and jh3y and removed request for a team April 26, 2024 15:43
@eps1lon eps1lon merged commit 8eb701c into canary Apr 26, 2024
80 checks passed
@eps1lon eps1lon deleted the sebbie/edge-route-size-comparison branch April 26, 2024 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants