Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain about the conditional default metadataBase on vercel de… #65583

Merged
merged 3 commits into from
May 10, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 9, 2024

Explain more details about default metadataBase (where metadataBase is not defined) when it's on Vercel deployment

x-ref: #65089

@huozhi huozhi requested review from a team as code owners May 9, 2024 19:00
@huozhi huozhi requested review from timeyoutakeit and leerob and removed request for a team May 9, 2024 19:00
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels May 9, 2024
@samcx
Copy link
Member

samcx commented May 9, 2024

@huozhi I feel like this points would be better if they were bullet points instead of just separate text 🤔

huozhi and others added 2 commits May 10, 2024 11:55
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@huozhi huozhi enabled auto-merge (squash) May 10, 2024 14:04
@huozhi huozhi merged commit ac55c79 into canary May 10, 2024
35 checks passed
@huozhi huozhi deleted the docs/update-metadata-base-default branch May 10, 2024 14:12
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
vercel#65583)

Explain more details about default `metadataBase` (where `metadataBase`
is not defined) when it's on Vercel deployment

x-ref: vercel#65089

---------

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants