Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change dynamic sitemap output filename #66273

Merged
merged 1 commit into from
May 28, 2024
Merged

docs: change dynamic sitemap output filename #66273

merged 1 commit into from
May 28, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 28, 2024

x-ref: #65507

Updating the dynamic sitemap routes output url to the one without .xml extension

@huozhi huozhi requested review from a team as code owners May 28, 2024 12:25
@huozhi huozhi requested review from timeyoutakeit and leerob and removed request for a team May 28, 2024 12:25
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels May 28, 2024
@huozhi huozhi mentioned this pull request May 28, 2024
Merged
eps1lon
eps1lon approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be best to highlight separately that we don't output .xml. People might have gotten used to it.

@huozhi huozhi merged commit c2d956d into canary May 28, 2024
34 checks passed
@huozhi huozhi deleted the docs/change-output-filename branch May 28, 2024 22:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob leerob was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @eps1lon @ijjk