Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: fix missing stylesheets when parallel routes are present #69507

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Aug 30, 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/docs/app/building-your-application/optimizing/package-bundling#analyzing-javascript-bundles link /docs/02-app/01-building-your-application/06-optimizing/13-memory-usage.mdx

Thank you 🙏

@ztanner ztanner force-pushed the zt/backport-css-fix branch from e73ee4a to 3770246 Compare August 30, 2024 18:29
@ijjk
Copy link
Member

ijjk commented Aug 30, 2024

Failing test suites

Commit: 3770246

TURBOPACK=1 pnpm test-start test/e2e/app-dir/parallel-routes-css/parallel-routes-css.test.ts (turbopack)

  • parallel-routes-catchall-css > should properly load the Head content from multiple leaf segments
Expand output

● parallel-routes-catchall-css › should properly load the Head content from multiple leaf segments

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 0, 0)"
Received: "rgba(0, 0, 0, 0)"

  33 |
  34 |     // the slot's background color should be red
> 35 |     expect(await getSlotBackgroundColor(browser)).toBe('rgb(255, 0, 0)')
     |                                                   ^
  36 |
  37 |     // there should no longer be a main element
  38 |     expect(await browser.hasElementByCssSelector('#main')).toBeFalsy()

  at Object.toBe (e2e/app-dir/parallel-routes-css/parallel-routes-css.test.ts:35:51)

Read more about building and testing Next.js in contributing.md.

@ztanner ztanner force-pushed the zt/backport-css-fix branch from 3770246 to c4d7545 Compare August 30, 2024 18:40
@ztanner ztanner marked this pull request as ready for review August 30, 2024 18:59
@ztanner ztanner requested a review from lubieowoce August 30, 2024 19:00
@ztanner ztanner merged commit 0e1bad0 into 14-2-1 Aug 30, 2024
70 of 80 checks passed
@ztanner ztanner deleted the zt/backport-css-fix branch August 30, 2024 19:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants