Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the example of ssr-caching to utilize the App Router. #69560

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Updated the example of ssr-caching to utilize the App Router. #69560

merged 15 commits into from
Sep 24, 2024

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the ssr-caching example for using the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 2, 2024
@ijjk
Copy link
Member

ijjk commented Sep 2, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: a679928

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review September 2, 2024 07:49
@PapatMayuri PapatMayuri marked this pull request as draft September 2, 2024 07:50
@PapatMayuri PapatMayuri marked this pull request as ready for review September 2, 2024 08:34
ijjk
ijjk previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment for changes

@samcx samcx self-requested a review September 24, 2024 20:31
@samcx samcx enabled auto-merge (squash) September 24, 2024 20:42
@samcx samcx self-requested a review September 24, 2024 20:42
@samcx samcx dismissed ijjk’s stale review September 24, 2024 20:42

It's been resolved!

@samcx samcx merged commit 7f798ca into vercel:canary Sep 24, 2024
38 checks passed
@github-actions github-actions bot added the locked label Oct 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk left review comments

@samcx samcx Awaiting requested review from samcx

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PapatMayuri @ijjk @samcx