Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: esm externals in turbopack #69590

Merged
merged 3 commits into from
Sep 3, 2024
Merged

backport: esm externals in turbopack #69590

merged 3 commits into from
Sep 3, 2024

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Sep 2, 2024 •
edited
Loading

@lubieowoce lubieowoce force-pushed the backport-14-3-0/esm-externals-turbopack branch 2 times, most recently from 8b583fb to f830de6 Compare September 3, 2024 12:35
@ijjk
Copy link
Member

ijjk commented Sep 3, 2024 •
edited
Loading

Tests Passed

@lubieowoce lubieowoce force-pushed the backport-14-3-0/esm-externals-turbopack branch 2 times, most recently from 33e9d08 to bf436e9 Compare September 3, 2024 12:56
wbinnssmith and others added 3 commits September 3, 2024 15:05
@wbinnssmith @kwonoj @lubieowoce
Turbopack: Allow client components from foreign code in app routes (#…
2c80812 
…64751)

This extends #64520 to cover cases where client components originate
from node_modules (foreign code).

Test Plan: Extended the integration test to cover this

Closes #64412
Fixes PACK-3014

---------

Co-authored-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com>
@lubieowoce
test: convert app-external.test.ts to nextTestSetup
dafdc81
@ForsakenHarmony @lubieowoce
feat(turbopack): add support for esm externals in app dir (#64918)
d09b769 
Writes the async flag to the client reference manifest to support ESM
externals in app dir.

The `app-ssr` context can't have esm externals as that might cause a
module to be async in ssr but not on the client.

Closes PACK-2967
Fixes #64525
@lubieowoce lubieowoce force-pushed the backport-14-3-0/esm-externals-turbopack branch from bf436e9 to d09b769 Compare September 3, 2024 13:05
@lubieowoce lubieowoce merged commit d09b769 into 14-2-1 Sep 3, 2024
51 of 57 checks passed
@lubieowoce lubieowoce deleted the backport-14-3-0/esm-externals-turbopack branch September 3, 2024 13:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@sokra sokra Awaiting requested review from sokra

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lubieowoce @ijjk @ForsakenHarmony @wbinnssmith