Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support React 18 in Pages Router" #69911

Conversation

timneutkens
Copy link
Member

Reverts #69484

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples tests type: next labels Sep 10, 2024
@timneutkens timneutkens marked this pull request as ready for review September 10, 2024 07:53
@ijjk
Copy link
Member

ijjk commented Sep 10, 2024

Failing test suites

Commit: a41b4e5

pnpm test-start test/e2e/app-dir/rsc-basic/rsc-basic.test.ts

  • app dir - rsc basics > should be able to navigate between rsc routes
Expand output

● app dir - rsc basics › should be able to navigate between rsc routes

request.allHeaders: Target page, context or browser has been closed

  168 |         page.on('request', (request) => {
  169 |           requestsCount++
> 170 |           return request.allHeaders().then((headers) => {
      |                          ^
  171 |             if (
  172 |               headers['RSC'.toLowerCase()] === '1' &&
  173 |               // Prefetches also include `RSC`

  at Page.allHeaders (e2e/app-dir/rsc-basic/rsc-basic.test.ts:170:26)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit 69f07b6 into canary Sep 10, 2024
98 of 103 checks passed
@timneutkens timneutkens deleted the revert-69484-sebbie/08-30-react-sync_cleanup_inaccurate_peer_dependencies branch September 10, 2024 08:20
ztanner added a commit that referenced this pull request Sep 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples locked tests type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants