Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(backport) fix(eslint): allow typescript-eslint v8 #70090

Merged

Conversation

alvarlagerlof
Copy link

What

Backported fix(eslint): allow typescript-eslint v8 #68807

Why

Unblocks upgrading eslint-config-next for projects already on typescript-eslint v8

@ijjk
Copy link
Member

ijjk commented Sep 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9a68836

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@alvarlagerlof
Copy link
Author

Please let me know if I did something incorrectly or any changes are needed. I think that this is my first PR to Next.js. I verified that the the updated test passes locally.

@ijjk
Copy link
Member

ijjk commented Sep 13, 2024

Stats from current PR

Default Build
General
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
buildDuration 17.4s 14.9s N/A
buildDurationCached 7.9s 6.9s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 414ms 404ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
1103-HASH.js gzip 31.6 kB 31.6 kB N/A
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 44.9 kB 44.9 kB
main-app-HASH.js gzip 243 B 244 B N/A
main-HASH.js gzip 32.2 kB 32.3 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 50.1 kB 50.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
_app-HASH.js gzip 195 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 501 B 506 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 259 B 258 B N/A
head-HASH.js gzip 350 B 352 B N/A
hooks-HASH.js gzip 372 B 371 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB
index-HASH.js gzip 259 B 258 B N/A
link-HASH.js gzip 2.68 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 315 B N/A
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4.9 kB 4.9 kB
Client Build Manifests
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
_buildManifest.js gzip 483 B 483 B
Overall change 483 B 483 B
Rendered Page Sizes
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.07 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
middleware-b..fest.js gzip 659 B 659 B
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.65 kB 1.65 kB
Next Runtimes
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.1 kB 98.1 kB
app-page-tur..prod.js gzip 99.8 kB 99.8 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page.run...dev.js gzip 145 kB 145 kB
app-page.run..prod.js gzip 92.6 kB 92.6 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 15.5 kB 15.5 kB
app-route-tu..prod.js gzip 15.5 kB 15.5 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 15.2 kB 15.2 kB
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.2 kB 23.2 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.5 kB 51.5 kB
Overall change 955 kB 955 kB
build cache
vercel/next.js 14-2-1 alvarlagerlof/next.js backport-eslint-allow-typescript-eslint-v8 Change
0.pack gzip 1.6 MB 1.6 MB N/A
index.pack gzip 114 kB 113 kB N/A
Overall change 0 B 0 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 9a68836

@ijjk ijjk merged commit 77910c8 into vercel:14-2-1 Sep 13, 2024
64 of 66 checks passed
@alvarlagerlof alvarlagerlof deleted the backport-eslint-allow-typescript-eslint-v8 branch September 13, 2024 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants