Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the example of with-three-js to utilize the App Router #70287

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Sep 20, 2024

This PR updates the with-three-js example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for /, /birds & /boxes files to align with the App Router.
  • Added the layout.tsx & tsconfig.json file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 20, 2024
@ijjk
Copy link
Member

ijjk commented Sep 20, 2024

Allow CI Workflow Run

  • approve CI run for commit: cd92239

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review September 20, 2024 13:29
Copy link

socket-security bot commented Sep 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@react-three/drei@9.112.1 Transitive: environment, filesystem, network +42 75.9 MB drcmda, giulioz, gsimone, ...2 more
npm/@react-three/fiber@8.17.7 environment +6 1.6 MB codyjasonbennett
npm/three@0.168.0 None 0 24.7 MB mrdoob, mugen87

🚮 Removed packages: npm/@react-three/drei@9.3.4, npm/@react-three/fiber@8.0.10, npm/three@0.139.2

View full report↗︎

@samcx samcx self-requested a review September 20, 2024 19:11
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx
Copy link
Member

samcx commented Sep 20, 2024

@Sam-Phillemon9493 I updated the tsconfig.json to the latest found in npx create-next-app@canary.

@samcx samcx enabled auto-merge (squash) September 20, 2024 19:25
@samcx samcx merged commit e3688fb into vercel:canary Sep 20, 2024
38 checks passed
@github-actions github-actions bot added the locked label Oct 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants