Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update app-dir-i18n-routing to v15 #72642

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

JamBalaya56562
Copy link
Contributor

Summary

Follow up #72636.
Bump 13 → 15 version in the description.

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 13, 2024
@ijjk
Copy link
Member

ijjk commented Nov 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 944dc71

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review November 13, 2024 18:22
@samcx
Copy link
Member

samcx commented Nov 13, 2024

@JamBalaya56562 In a separate PR, we could also possibly just remove app-dir in the directory name (I believe two examples do this), since the default is already App Router anyways and a lot of examples have migrated over. The Page Router examples can keep a pages-<xyz> name.

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit f3e2f87 into vercel:canary Nov 13, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the v15 branch November 13, 2024 23:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants