-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apollo example with next.js #733
Conversation
Not a big fan of submodules. Would it make sense to check it in statically? |
Thanks for the contribution! |
Will do |
@rauchg Should be done. Btw travis ci build failed because no node env was set? |
Oh, seems like linting issues. Please run the linter on the new directory. |
Run " npm run lint " in the main next.js directory rather in the example directory. |
Thanks @donedgardo - let's hold off on this? @sedubois and I have been hardening a simplified react apollo example over at https://github.com/ads1018/next-apollo-example |
Fixed linting issues. |
I'd like to have a more minimalistic example, something that only does the apollo data wrapping (minus all the stylesheets, external fonts, etc). Maybe @ads1018 can contribute some ideas on how to make the most to-the-point Apollo example here? |
I could simplify it with only rendering one component connected to apollo. |
@rauchg definitely. A lot of our thoughts have been captured towards the end of the apollo example issue. I'll follow up with a summary of the minimalistic approach we took in our example. |
@donedgardo @rauchg I ended up creating a separate pull request since I took a different approach. In my example, I simply wrap the page inside a higher-order component I created called On initial page load, while on the server and inside the HOC |
@donedgardo @ads1018 Thank you both so much for you contribution. This is pretty awesome. I think we should close one and work together on the best solution. From the looks of it #780 is more minimalistic. What do you guys think? |
The other example has been merged so I think this can be closed 👍 |
Done 👍🏻 |
No description provided.