-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use React 19 stable for related packages and types #73579
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react-dom@19.0.0-rc-1c9b1387-20241204, npm/react-is@19.0.0-rc-1c9b1387-20241204, npm/react-server-dom-turbopack@19.0.0-rc-1c9b1387-20241204, npm/react-server-dom-webpack@19.0.0-rc-1c9b1387-20241204, npm/react@19.0.0-rc-1c9b1387-20241204 |
You changed the vendored version of React we use in the App Router. It's automatically updated with the latest |
@eps1lon is it planned to go back to non-canary versions of Eg. usage of The reason I ask is that automated npm package upgraders like Renovate bot and Dependabot will automatically bump the versions of Why not just disable the automated upgrades for I have come up with a workaround for this in the interim - using GitHub Actions workflows and a shell script to fix the version numbers after the bots upgrade to mismatching But ideally there would be a more bulletproof way to allow these upgrader bots to upgrade to the latest stable versions of all packages (eg. as it was before Next.js started requiring canary versions of Alternative: Next.js could stop requiring |
Yes. If Renovate is doing upgrades that create conflicting peer dependencies, I'd file that against their repo. The version of React in
I don't see how this would be frequent. The latest version of Next.js was always immediately supporting the latest version of React so there should rarely be a long period of mismatch. |
Oh nice, I saw yesterday that the latest reproduction template already uses
Can confirm that ➜ p mkdir a
➜ p cd a
➜ a pnpm create next-app@latest . --app --no-turbopack --no-src-dir --no-eslint --import-alias @/\* --no-tailwind --typescript
.../193afd0e5d9-9dc4 | +1 +
.../193afd0e5d9-9dc4 | Progress: resolved 1, reused 0, downloaded 1, added 1, done
Creating a new Next.js app in /Users/k/p/a.
Using pnpm.
Initializing project with template: app
Installing dependencies:
- react
- react-dom
- next
Installing devDependencies:
- typescript
- @types/node
- @types/react
- @types/react-dom
! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing pnpm@9.14.4+sha512.c8180b3fbe4e4bca02c94234717896b5529740a6cbadf19fa78254270403ea2f27d4e1d46a08a0f56c89b63dc8ebfd3ee53326da720273794e6200fcf0d184ab.
! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager
Packages: +35
+++++++++++++++++++++++++++++++++++
Progress: resolved 60, reused 34, downloaded 2, added 35, done
dependencies:
+ next 15.0.4
+ react 19.0.0
+ react-dom 19.0.0
devDependencies:
+ @types/node 20.17.9 (22.10.1 is available)
+ @types/react 19.0.1
+ @types/react-dom 19.0.2
+ typescript 5.7.2
Done in 2.7s
Initialized a git repository.
Success! Created a at /Users/k/p/a
➜ a git:(main) cat package.json
{
"name": "a",
"version": "0.1.0",
"private": true,
"scripts": {
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "next lint"
},
"dependencies": {
"react": "^19.0.0",
"react-dom": "^19.0.0",
"next": "15.0.4"
},
"devDependencies": {
"typescript": "^5",
"@types/node": "^20",
"@types/react": "^19",
"@types/react-dom": "^19"
},
"packageManager": "pnpm@9.14.4+sha512.c8180b3fbe4e4bca02c94234717896b5529740a6cbadf19fa78254270403ea2f27d4e1d46a08a0f56c89b63dc8ebfd3ee53326da720273794e6200fcf0d184ab"
} I'll upgrade to the non-canary |
Follow up to this PR: #73564, updated package that can be updated to stable version instead of RC.