create-next-app: default to ESLint disabled

[leerob]

You can optionally enable it, if desired, but this gives you one less config file by default.

[ijjk]

Failing test suites

Commit: 0aa2514

pnpm test test/integration/create-next-app/prompts.test.ts

• create-next-app prompts > should not prompt user for choice and use defaults if --yes is defined

Expand output

● create-next-app prompts › should not prompt user for choice and use defaults if --yes is defined

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  83 |   for (const file of files) {
  84 |     try {
> 85 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  86 |     } catch (err) {
  87 |       require('console').error(
  88 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:85:54)
  at ChildProcess.<anonymous> (integration/create-next-app/prompts.test.ts:192:34)

● create-next-app prompts › should not prompt user for choice and use defaults if --yes is defined

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  176 |   })
  177 |
> 178 |   it('should not prompt user for choice and use defaults if --yes is defined', async () => {
      |   ^
  179 |     await useTempDir(async (cwd) => {
  180 |       const projectName = 'yes-we-can'
  181 |       const childProcess = createNextApp(

  at it (integration/create-next-app/prompts.test.ts:178:3)
  at Object.describe (integration/create-next-app/prompts.test.ts:5:1)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
buildDuration	21.2s	19s	N/A
buildDurationCached	18s	15.3s	N/A
nodeModulesSize	410 MB	410 MB	N/A
nextStartRea..uration (ms)	527ms	526ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
1187-HASH.js gzip	50.8 kB	50.8 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.36 kB	5.36 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	34 kB	34 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.49 kB	4.49 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
_buildManifest.js gzip	747 B	746 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
index.html gzip	524 B	522 B	N/A
link.html gzip	539 B	537 B	N/A
withRouter.html gzip	520 B	519 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
middleware-b..fest.js gzip	670 B	667 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.2 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
523-experime...dev.js gzip	322 B	322 B	✓
523.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	323 kB	323 kB	✓
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	313 kB	313 kB	✓
app-page.run..prod.js gzip	123 kB	123 kB	✓
app-route-ex...dev.js gzip	37.3 kB	37.3 kB	✓
app-route-ex..prod.js gzip	25.4 kB	25.4 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route-tu..prod.js gzip	25.2 kB	25.2 kB	✓
app-route.ru...dev.js gzip	38.9 kB	38.9 kB	✓
app-route.ru..prod.js gzip	25.2 kB	25.2 kB	✓
pages-api-tu..prod.js gzip	9.67 kB	9.67 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.66 kB	9.66 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.4 kB	27.4 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.36 MB	2.36 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js disable-eslint-cna	Change
0.pack gzip	2.05 MB	2.05 MB	⚠️ +405 B
index.pack gzip	72.6 kB	71.5 kB	N/A
Overall change	2.05 MB	2.05 MB	⚠️ +405 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 0aa2514

[ijjk]

looks like we need to update our prompt tests for this change

[feedthejim]

holding until we further discuss this decision