Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fallback route params to prerender manifest #74004

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Dec 16, 2024

In order for the root parameters to be added to the cache key within Vercel, we need to include the rootParams in the prerender-manfest.json.

@ijjk
Copy link
Member

ijjk commented Dec 16, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
buildDuration 39.1s 34s N/A
buildDurationCached 33.9s 28.1s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +2 kB
nextStartRea..uration (ms) 1s 913ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
1187-HASH.js gzip 51.4 kB 51.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 234 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 324 kB 324 kB
app-page-exp..prod.js gzip 128 kB 128 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page-tur..prod.js gzip 136 kB 136 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 124 kB 124 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39 kB 39 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/added-fallback-route-params-manifest Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +1.57 kB
index.pack gzip 74.1 kB 74.3 kB ⚠️ +200 B
Overall change 2.15 MB 2.15 MB ⚠️ +1.77 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 4141a5b

@wyattjoh wyattjoh marked this pull request as ready for review December 16, 2024 22:12
@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch from d5027c3 to f8063e7 Compare December 16, 2024 22:17
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from a9389c8 to 4f61386 Compare December 16, 2024 22:17
@wyattjoh wyattjoh requested a review from ztanner December 16, 2024 22:18
@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch from f8063e7 to 2d00545 Compare December 16, 2024 22:30
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from 4f61386 to 1dfd9d7 Compare December 16, 2024 22:30
@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch from 2d00545 to d57b374 Compare December 16, 2024 23:44
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from 1dfd9d7 to 980d8e4 Compare December 16, 2024 23:45
@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch from d57b374 to 768a253 Compare December 17, 2024 16:29
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from 980d8e4 to e1c1032 Compare December 17, 2024 16:29
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch from 768a253 to 1d7ce5a Compare December 17, 2024 17:17
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from e1c1032 to 8b5a0e0 Compare December 17, 2024 17:18
@wyattjoh wyattjoh force-pushed the feat/error-for-missing-root-params branch 2 times, most recently from 2e244ed to 79b8c7e Compare December 17, 2024 17:57
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from 8b5a0e0 to db72c45 Compare December 17, 2024 17:57
@wyattjoh wyattjoh changed the base branch from feat/error-for-missing-root-params to graphite-base/74004 December 17, 2024 18:25
@wyattjoh wyattjoh force-pushed the graphite-base/74004 branch from 79b8c7e to d7d913a Compare December 17, 2024 18:25
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from db72c45 to 2b59da1 Compare December 17, 2024 18:25
@wyattjoh wyattjoh changed the base branch from graphite-base/74004 to canary December 17, 2024 18:25
@wyattjoh wyattjoh force-pushed the feat/added-fallback-route-params-manifest branch from 2b59da1 to 4141a5b Compare December 17, 2024 18:26
@wyattjoh wyattjoh merged commit 62fb78b into canary Dec 17, 2024
125 of 130 checks passed
Copy link
Member Author

Merge activity

  • Dec 17, 1:47 PM EST: A user merged this pull request with Graphite.

@wyattjoh wyattjoh deleted the feat/added-fallback-route-params-manifest branch December 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants