Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name default Jest project according to used env variables #74084

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 18, 2024

You can run Turbopack tests both with --projects and TURBOPACK env variable.
However, only the --projects used the correct display name.

Now specifying TURBOPACK=1 will correctly label the project with "turbopack":
PASS turbopack test/integration/server-side-dev-errors/test/index.test.js (25.696 s)

You can run Turbopack both with `--projects` and `TURBOPACK`
env variable.
Howevery, only the  `--projects` used the correct display name.

Now specifying `TURBOPACK=1` will correctly label the project
with "turbopack":
` PASS   turbopack  test/integration/server-side-dev-errors/test/index.test.js (25.696 s)`
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 18, 2024
Copy link
Member Author

eps1lon commented Dec 18, 2024

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
buildDuration 19.5s 15.9s N/A
buildDurationCached 15.1s 12.6s N/A
nodeModulesSize 416 MB 416 MB N/A
nextStartRea..uration (ms) 470ms 479ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
middleware-b..fest.js gzip 667 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 356 kB 356 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 346 kB 346 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.43 MB 2.43 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/12-18-name_default_jest_project_according_to_used_env_variables Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +1.98 kB
index.pack gzip 73.9 kB 73.9 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +1.98 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 12329c1

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Tests Passed

@eps1lon eps1lon marked this pull request as ready for review December 18, 2024 17:41
@eps1lon eps1lon requested a review from huozhi December 18, 2024 17:41
@eps1lon eps1lon merged commit 764f885 into canary Dec 18, 2024
130 checks passed
@eps1lon eps1lon deleted the sebbie/12-18-name_default_jest_project_according_to_used_env_variables branch December 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants