Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(turbopack): Ignore no-vc-struct lint in trybuild proc macro tests #74110

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore(turbopack): Ignore no-vc-struct lint in trybuild proc macro tests #74110

merged 1 commit into from
Dec 20, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 18, 2024 •
edited by padmaia
Loading

These tests exist to see that the compiler generates errors when doing similar things to what the lint is designed to catch.

I'd rather exempt these in the lint than in the trybuild tests, as once we get rid of support for the local opt-out in the turbo_tasks::value macro, we shouldn't need the lint anymore (it won't be possible to compile code using an unresolved Vc in a VcValueType), but we still will need these trybuild tests.

Closes PACK-3673

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Dec 18, 2024
@bgw bgw mentioned this pull request Dec 18, 2024
Closed
@bgw Graphite App
Copy link
Member Author

bgw commented Dec 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw requested review from kdy1 and mischnic December 18, 2024 23:57
@bgw bgw marked this pull request as ready for review December 18, 2024 23:58
@ijjk
Copy link
Member

ijjk commented Dec 19, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
buildDuration 21.6s 20.1s N/A
buildDurationCached 19.1s 15.9s N/A
nodeModulesSize 416 MB 416 MB ✓
nextStartRea..uration (ms) 540ms 551ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 236 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 537 B ✓
withRouter.html gzip 518 B 520 B N/A
Overall change 537 B 537 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 359 kB 359 kB ✓
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page-tur..prod.js gzip 137 kB 137 kB ✓
app-page.run...dev.js gzip 348 kB 348 kB ✓
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.4 kB 37.4 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.3 kB 25.3 kB ✓
app-route.ru...dev.js gzip 39.1 kB 39.1 kB ✓
app-route.ru..prod.js gzip 25.3 kB 25.3 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.44 MB 2.44 MB ✓
build cache
vercel/next.js canary vercel/next.js bgw/ignore-trybuild-tests-in-lint Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 73.4 kB 73.5 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 56a4c25

@ijjk
Copy link
Member

ijjk commented Dec 19, 2024 •
edited
Loading

Tests Passed

This was referenced Dec 19, 2024
Merged
Merged
@bgw bgw force-pushed the bgw/ignore-trybuild-tests-in-lint branch from d24c0c6 to 56a4c25 Compare December 20, 2024 01:50
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. tests Turbopack Related to Turbopack with Next.js. type: next labels Dec 20, 2024
@bgw bgw changed the base branch from bgw/resolved-vc-swc-issue-collector to canary December 20, 2024 01:50
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-518d06d2-20241219 None 0 8.33 MB fb, gnoff, react-bot, ...2 more
npm/react-dom@19.1.0-canary-518d06d2-20241219 None 0 6.37 MB fb, gnoff, react-bot, ...2 more
npm/react-is@19.1.0-canary-518d06d2-20241219 None 0 13.6 kB fb, gnoff, react-bot, ...1 more
npm/react-server-dom-turbopack@0.0.0-experimental-518d06d2-20241219 None +1 1.38 MB react-bot
npm/react-server-dom-turbopack@19.1.0-canary-518d06d2-20241219 None +1 1.28 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-518d06d2-20241219 None +1 1.86 MB react-bot
npm/react-server-dom-webpack@19.1.0-canary-518d06d2-20241219 None +1 1.72 MB react-bot
npm/react@0.0.0-experimental-518d06d2-20241219 None 0 177 kB fb, gnoff, react-bot, ...1 more
npm/react@19.1.0-canary-518d06d2-20241219 None 0 238 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.0.0-experimental-518d06d2-20241219 None 0 82.1 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.26.0-canary-518d06d2-20241219 None 0 82.7 kB fb, gnoff, react-bot, ...1 more

🚮 Removed packages: npm/react-dom@0.0.0-experimental-372ec00c-20241209, npm/react-dom@19.0.0-rc-372ec00c-20241209, npm/react-is@19.0.0-rc-372ec00c-20241209, npm/react-server-dom-turbopack@0.0.0-experimental-372ec00c-20241209, npm/react-server-dom-turbopack@19.0.0-rc-372ec00c-20241209, npm/react-server-dom-webpack@0.0.0-experimental-372ec00c-20241209, npm/react-server-dom-webpack@19.0.0-rc-372ec00c-20241209, npm/react@0.0.0-experimental-372ec00c-20241209, npm/react@19.0.0-rc-372ec00c-20241209, npm/scheduler@0.0.0-experimental-372ec00c-20241209, npm/scheduler@0.25.0-rc-372ec00c-20241209

View full report↗︎

@bgw bgw merged commit 5e0079e into canary Dec 20, 2024
54 of 59 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Dec 20, 2024

Merge activity

  • Dec 19, 9:05 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/ignore-trybuild-tests-in-lint branch December 20, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@mischnic mischnic Awaiting requested review from mischnic

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1