refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3)

[bgw]

OperationVcs should be used with CollectiblesSource instead of Vcs because collectibles represent a side-effect or implicit extra return value of a function's execution.

[bgw]

• refactor(turbopack/next-api): Make VcArc use OperationVc #74479
• refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 3/3) #74173
• refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3) #74168 👈 (View in Graphite)
• refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 1/3) #74051
• refactor(turbo-tasks): Make State require OperationValue #73876
• refactor(turbo-tasks): Remove public OperationVc constructor, introduce a macro annotation for creating OperationVc types #72871
• refactor(turbopack): Make various types directly or indirectly included in State<T> types into OperationValues and/or NonLocalValues #74008
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: d36441f

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

• ReactRefreshRequire > propagates a hot update to closest accepted module

Expand output

● ReactRefreshRequire › propagates a hot update to closest accepted module

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
    "init FooV1",
+   "init FooV1",
    "init BarV3",
  ]

  119 |     await session.evaluate(() => ((window as any).log = []))
  120 |     await session.patch('./bar.js', `window.log.push('init BarV3');`)
> 121 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  122 |       // // FIXME: Metro order:
  123 |       // 'init BarV3',
  124 |       // 'init FooV1',

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:121:63)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
buildDuration	20s	17.6s	N/A
buildDurationCached	16.8s	14.2s	N/A
nodeModulesSize	416 MB	416 MB	✓
nextStartRea..uration (ms)	488ms	488ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
1187-HASH.js gzip	52.4 kB	52.4 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.36 kB	5.36 kB	N/A
bccd1874-HASH.js gzip	52.8 kB	52.8 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	34.1 kB	34.1 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.49 kB	4.49 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
_buildManifest.js gzip	749 B	746 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
index.html gzip	524 B	522 B	N/A
link.html gzip	538 B	536 B	N/A
withRouter.html gzip	520 B	519 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	206 kB	206 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
middleware-b..fest.js gzip	669 B	665 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.2 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	359 kB	359 kB	✓
app-page-exp..prod.js gzip	129 kB	129 kB	✓
app-page-tur..prod.js gzip	142 kB	142 kB	✓
app-page-tur..prod.js gzip	137 kB	137 kB	✓
app-page.run...dev.js gzip	348 kB	348 kB	✓
app-page.run..prod.js gzip	125 kB	125 kB	✓
app-route-ex...dev.js gzip	37.5 kB	37.5 kB	✓
app-route-ex..prod.js gzip	25.5 kB	25.5 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.44 MB	2.44 MB	✓

build cache

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt2	Change
0.pack gzip	2.08 MB	2.08 MB	N/A
index.pack gzip	74.3 kB	73.3 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: d36441f