Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React from 518d06d2-20241219 to 97d79495-20241223 #74281

Open
wants to merge 6 commits into
base: canary
Choose a base branch
from
Open

Upgrade React from 518d06d2-20241219 to 97d79495-20241223 #74281

wants to merge 6 commits into from

Conversation

vercel-release-bot
Copy link
Collaborator

@ijjk ijjk added CI approved Approve running CI for fork type: next labels Dec 24, 2024
@ijjk
Copy link
Member

ijjk commented Dec 24, 2024 •
edited
Loading

Failing test suites

Commit: ebf489e

pnpm test test/integration/amp-export-validation/test/index.test.js (turbopack)

  • AMP Validation on Export > production mode > should have shown errors during build
Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.1.1-canary.18 (Turbopack)·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Building (0/7) ...
   Building (1/7)··
   Building (3/7)··
   Building (5/7)··
 ✓ Building (7/7)
 ✓ Compiled successfully in 3.9s
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/second\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:102:1441)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:103:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:104:374)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2238:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:106:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:123:13)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:156:20)
  at async exportPage (../packages/next/dist/export/worker.js:349:18)
  Export encountered an error on /second, exiting the build.
   ⨯ Static worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/search-params-react-key/layout-params.test.ts

  • app dir - search params keys > should keep the React router instance the same when changing the search params
Expand output

● app dir - search params keys › should keep the React router instance the same when changing the search params

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#search-params')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
buildDuration 18.4s 15.6s N/A
buildDurationCached 14.9s 12.6s N/A
nodeModulesSize 416 MB 416 MB N/A
nextStartRea..uration (ms) 396ms 400ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 538 B N/A
withRouter.html gzip 518 B 520 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
middleware-b..fest.js gzip 669 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 359 kB 359 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB N/A
app-page.run...dev.js gzip 347 kB 347 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.5 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.4 kB 25.4 kB N/A
app-route.ru...dev.js gzip 39.2 kB 39.2 kB N/A
app-route.ru..prod.js gzip 25.4 kB 25.4 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 103 kB 103 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-97d79495-20241223 Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +1.91 kB
index.pack gzip 74 kB 75.1 kB ⚠️ +1.1 kB
Overall change 2.15 MB 2.16 MB ⚠️ +3 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js 
failed to diff
Commit: ebf489e

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-97d79495-20241223 None 0 8.33 MB react-bot
npm/react-dom@19.1.0-canary-97d79495-20241223 None 0 6.37 MB react-bot
npm/react-is@19.1.0-canary-97d79495-20241223 None 0 13.6 kB fb, gnoff, react-bot, ...1 more
npm/react-server-dom-turbopack@0.0.0-experimental-97d79495-20241223 None +1 1.38 MB react-bot
npm/react-server-dom-turbopack@19.1.0-canary-97d79495-20241223 None +1 1.28 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-97d79495-20241223 None +1 1.86 MB react-bot
npm/react-server-dom-webpack@19.1.0-canary-97d79495-20241223 None +1 1.72 MB react-bot
npm/react@0.0.0-experimental-97d79495-20241223 None 0 177 kB fb, gnoff, react-bot, ...1 more
npm/react@19.1.0-canary-97d79495-20241223 None 0 238 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.0.0-experimental-97d79495-20241223 environment 0 82.1 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.26.0-canary-97d79495-20241223 environment 0 82.7 kB fb, gnoff, react-bot, ...1 more

🚮 Removed packages: npm/react-dom@0.0.0-experimental-518d06d2-20241219, npm/react-dom@19.1.0-canary-518d06d2-20241219, npm/react-is@19.1.0-canary-518d06d2-20241219, npm/react-server-dom-turbopack@0.0.0-experimental-518d06d2-20241219, npm/react-server-dom-turbopack@19.1.0-canary-518d06d2-20241219, npm/react-server-dom-webpack@0.0.0-experimental-518d06d2-20241219, npm/react-server-dom-webpack@19.1.0-canary-518d06d2-20241219, npm/react@0.0.0-experimental-518d06d2-20241219, npm/react@19.1.0-canary-518d06d2-20241219, npm/scheduler@0.0.0-experimental-518d06d2-20241219, npm/scheduler@0.26.0-canary-518d06d2-20241219

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon Awaiting requested review from eps1lon

At least 1 approving review is required to merge this pull request.

Assignees

@eps1lon eps1lon

Labels
CI approved Approve running CI for fork type: next type: react-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vercel-release-bot @ijjk @eps1lon