Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure lastAppProps always have some value. #829

Merged
merged 4 commits into from
Jan 20, 2017
Merged

Make sure lastAppProps always have some value. #829

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4ae722
Make sure lastAppProps always have some value.
arunoda Jan 19, 2017
24eca37
Revert "Make sure lastAppProps always have some value."
arunoda Jan 20, 2017
37fd53f
Throw an error, if we found an empty object from getInitialProps.
arunoda Jan 20, 2017
ce12bd9
Add proper tests for getInitialProps empty check.
arunoda Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const {

const Component = evalScript(component).default
const ErrorComponent = evalScript(errorComponent).default
let lastAppProps
let lastAppProps = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the props became null our code tries to read the props from lastAppProps.

Then, For the very first doRender call, it tries to check few items from this lastAppProps. Unfortunately, it's a null and we'll get the mentioned problem.


export const router = createRouter(pathname, query, {
Component,
Expand Down