Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-zones example #8459

Merged
merged 16 commits into from
Aug 27, 2019
Merged

Update with-zones example #8459

merged 16 commits into from
Aug 27, 2019

Conversation

borekb
Copy link
Contributor

@borekb borekb commented Aug 21, 2019 •
edited
Loading

Sparked by discussions in #7488, #8426, #8440 and this Spectrum thread, I wanted to make sure that the with-zones example works and that it demonstrates all the challenges with multi-zones setup.

Main changes in this PR:

Original description

Specifically, things that were not clear to me:

  1. Why there are two separate routing rules in now.json for blog: 
    {
  "routes": [
    { "src": "/blog/_next(.*)", "dest": "blog/_next$1" },
    { "src": "/blog", "dest": "blog/blog" }
  ]
}
  2. Is "dest": "blog/blog" correct? Seems like "one 'blog' too many".
  3. Does it work with Next.js 9 dynamic routing?
  4. Should continue: true be added? It's supposed to be used according to Update Zones Documentation #8426 (comment).

When playing with the example, I've done these main changes:

  • Added blog/pages/blog/post/[id].js page to showcase dynamic routing. af0a909
  • Added dynamic assetPrefix configuration so that the 'blog' app can run both separately via next dev and together with 'home' in a multi-zoned app, via now dev. d75c6c9
  • Updated README to explain all the non-obvious things. 67049e2

I also tried adding continue: true, with now.json looking like this:

{
  "builds": [
    { "src": "blog/next.config.js", "use": "@now/next" },
    { "src": "home/next.config.js", "use": "@now/next" }
  ],
  "routes": [
    { "src": "/blog(.*)", "dest": "blog$1", "continue": true },
    { "src": "(?!/?blog)(.*)", "dest": "home$1", "continue": true }
  ]
}

However, that was not working for me at all – localhost:3000 just displaying technical Now pages like directory listings. @Timer, am I doing something wrong here? (I have to admit that I prefer the older way anyway as I don't need to do negative lookaheads but still...)

@borekb
Add more pages to the 'blog' zone
af0a909 
- New dynamic page `pages/blog/post/[id].js`
- `pages/blog.js` moved to `pages/blog/index.js`
@borekb
Update Now and Next configs to support both now dev and next dev
d75c6c9 
- Set `assetPrefix` dynamically to either `/blog` or `''`.
- Update package.json scripts for both 'home' and 'blog' apps, support `yarn dev` in both of them.
@borekb
Update example description in README
67049e2
This was referenced Aug 21, 2019
Closed
Closed
@ijjk
Copy link
Member

ijjk commented Aug 21, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 24.3s 24.2s -165ms
nodeModulesSize 41.2 MB 41.2 MB -36 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.74 kB 3.74 kB ✓
link gzip 962 B 956 B -6 B
index 3.69 kB 3.69 kB ✓
index gzip 954 B 948 B -6 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 948 B 943 B -5 B
Overall change ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.7s 26.1s ⚠️ +465ms
nodeModulesSize 41.2 MB 41.2 MB -36 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.3 kB ⚠️ +51 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 979 B 981 B ⚠️ +2 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB -33 B
link.js 256 kB 256 kB ✓
link.js gzip 68.8 kB 68.8 kB ⚠️ +49 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.8 kB 66.7 kB -30 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.7 kB 66.7 kB ⚠️ +5 B
Overall change ✓

@ijjk
Copy link
Member

ijjk commented Aug 21, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 19.3s 19.3s ⚠️ +21ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.62 kB 6.62 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 434 B 434 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 866 B 866 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 805 B 805 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 430 B 430 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.75 kB 3.75 kB ✓
link gzip 963 B 965 B ⚠️ +2 B
index 3.69 kB 3.69 kB ✓
index gzip 954 B 956 B ⚠️ +2 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 949 B 951 B ⚠️ +2 B
Overall change ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 21.1s 21s -146ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB -8 B
_error.js gzip 66.3 kB 66.3 kB ⚠️ +9 B
hooks.html 3.81 kB 3.81 kB -3 B
hooks.html gzip 979 B 979 B ✓
index.js 248 kB 248 kB -8 B
index.js gzip 66.6 kB 66.8 kB ⚠️ +205 B
link.js 256 kB 256 kB -8 B
link.js gzip 68.8 kB 68.9 kB ⚠️ +98 B
routerDirect.js 249 kB 249 kB -8 B
routerDirect.js gzip 66.6 kB 66.7 kB ⚠️ +87 B
withRouter.js 249 kB 249 kB -8 B
withRouter.js gzip 66.7 kB 66.9 kB ⚠️ +207 B
Overall change -43 B

@ijjk
Copy link
Member

ijjk commented Aug 21, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 22.2s 21.8s -396ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.74 kB 3.75 kB ⚠️ +3 B
link gzip 962 B 963 B ⚠️ +1 B
index 3.69 kB 3.69 kB ⚠️ +3 B
index gzip 954 B 955 B ⚠️ +1 B
withRouter 3.75 kB 3.75 kB ⚠️ +3 B
withRouter gzip 949 B 949 B ✓
Overall change ⚠️ +9 B
Serverless Mode
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.3s 23.4s ⚠️ +76ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.3 kB -34 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 979 B 977 B -2 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.5 kB -49 B
link.js 256 kB 256 kB ✓
link.js gzip 68.9 kB 68.9 kB ⚠️ +41 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.7 kB 66.6 kB -76 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.7 kB 66.7 kB ⚠️ +2 B
Overall change ✓

@borekb
Copy link
Contributor Author

borekb commented Aug 21, 2019 •
edited
Loading

How strange: next dev works fine, now dev works fine but when I deploy it to Now, half of the app is broken:

https://with-zones-d0hphztnm.now.sh/blog

Screenshot 2019-08-21 at 17 33 54

With now dev:

Screenshot 2019-08-21 at 17 37 12

I have another project (a private one) where I use the same now.json config as in this PR and that works fine when deployed to Now. 🤷‍♂

@ijjk
Copy link
Member

ijjk commented Aug 21, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 24.6s 23.9s -702ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +65 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.74 kB 3.74 kB -1 B
link gzip 962 B 964 B ⚠️ +2 B
index 3.69 kB 3.69 kB -1 B
index gzip 955 B 956 B ⚠️ +1 B
withRouter 3.75 kB 3.75 kB -1 B
withRouter gzip 949 B 951 B ⚠️ +2 B
Overall change -3 B
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.7s 25.7s -41ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +65 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ⚠️ +34 B
_error.js gzip 66.3 kB 66.3 kB ⚠️ +52 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 980 B 976 B -4 B
index.js 248 kB 248 kB ⚠️ +34 B
index.js gzip 66.7 kB 66.8 kB ⚠️ +62 B
link.js 256 kB 256 kB ⚠️ +34 B
link.js gzip 68.9 kB 68.8 kB -69 B
routerDirect.js 249 kB 249 kB ⚠️ +34 B
routerDirect.js gzip 66.6 kB 66.6 kB -48 B
withRouter.js 249 kB 249 kB ⚠️ +34 B
withRouter.js gzip 66.7 kB 66.9 kB ⚠️ +222 B
Overall change ⚠️ +170 B

@ijjk
Copy link
Member

ijjk commented Aug 21, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.7s 23.6s -86ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +65 B
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB -1 B
main-HASH.js gzip 6.63 kB 6.62 kB -1 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change -1 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB -1 B
main-HASH.module.js gzip 6.36 kB 6.36 kB -1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change -1 B
Client Pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ⚠️ +1 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ⚠️ +1 B
routerDirect.js 433 B 434 B ⚠️ +1 B
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ⚠️ +1 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 866 B -1 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 805 B ⚠️ +1 B
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 430 B ⚠️ +1 B
withRouter.module.js gzip 293 B 293 B ✓
Overall change ⚠️ +1 B
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.74 kB 3.75 kB ⚠️ +1 B
link gzip 962 B 966 B ⚠️ +4 B
index 3.69 kB 3.69 kB ⚠️ +1 B
index gzip 954 B 958 B ⚠️ +4 B
withRouter 3.75 kB 3.75 kB ⚠️ +1 B
withRouter gzip 949 B 953 B ⚠️ +4 B
Overall change ⚠️ +3 B
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.6s 25.4s -159ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +65 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ⚠️ +23 B
_error.js gzip 66.4 kB 66.4 kB ⚠️ +2 B
hooks.html 3.81 kB 3.81 kB -5 B
hooks.html gzip 974 B 978 B ⚠️ +4 B
index.js 248 kB 248 kB ⚠️ +18 B
index.js gzip 66.8 kB 66.6 kB -131 B
link.js 256 kB 256 kB ⚠️ +18 B
link.js gzip 68.9 kB 68.9 kB -3 B
routerDirect.js 249 kB 249 kB ⚠️ +18 B
routerDirect.js gzip 66.9 kB 66.9 kB ⚠️ +7 B
withRouter.js 249 kB 249 kB ⚠️ +18 B
withRouter.js gzip 66.6 kB 66.9 kB ⚠️ +262 B
Overall change ⚠️ +90 B

lfades
lfades previously requested changes Aug 21, 2019
View reviewed changes
Copy link
Member

@lfades lfades left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borekb Just to be clear, we don't recommend the setup in this example, instead we would prefer to always use a single application for all cases, having multiple Next.js doesn't helps for anything (correct me if I'm wrong).

The example will be too complicated and confusing with these changes. I would prefer to fix the example, because it seems to not be working now, instead of adding a lot of changes to it, specially in the readme.

@borekb
Copy link
Contributor Author

borekb commented Aug 21, 2019

The README is currently too long, I agree and plan to edit it down. The rest of the PR, though, I'm not sure how to make much smaller – maybe remove dynamic routing (which I added because of #7488) but the rest of it are healthy fixes and improvements, IMO.

Regarding the use case, we have a monorepo with several separate Next.js apps and use Now with GitHub integration for deployment. As the integration only reads a single now.json file, we have to host the Next.js apps side by side, and because of the lack of basepath support in Next.js (#4998), multi-zones are our only option. Zeit docs also use a similar setup and more scenarios are discussed in #257, #4998 and similar issues.

To be clear, I'm not using the zones feature out of joy but because I don't see any other way in our scenario (I'm praying for basepath support 😄). I spent quite a lot of time struggling with the setup, the diff is relatively small in the end (if you skip the README) but there are many details to get wrong.

@borekb
Shorten README
37e6d45 
I reverted it back to the state of 233152e and then updated it with info on recent changes of the `with-zones` example.
@borekb
Merge remote-tracking branch 'upstream/canary' into with-zones-exampl…
9a5b6e2 
…e-update
@ijjk
Copy link
Member

ijjk commented Aug 22, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.1s 23.8s -1.3s
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ⚠️ +1 B
main-HASH.js gzip 6.62 kB 6.63 kB ⚠️ +1 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ⚠️ +1 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ⚠️ +1 B
main-HASH.module.js gzip 6.36 kB 6.36 kB ⚠️ +1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ⚠️ +1 B
Client Pages Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB -1 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 434 B 433 B -1 B
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change -1 B
Client Pages Modern Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 866 B 867 B ⚠️ +1 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 805 B 804 B -1 B
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 430 B 429 B -1 B
withRouter.module.js gzip 293 B 293 B ✓
Overall change -1 B
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.74 kB 3.75 kB ⚠️ +3 B
link gzip 963 B 962 B -1 B
index 3.69 kB 3.69 kB ⚠️ +3 B
index gzip 955 B 953 B -2 B
withRouter 3.75 kB 3.75 kB ⚠️ +3 B
withRouter gzip 949 B 948 B -1 B
Overall change ⚠️ +9 B
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25s 26.1s ⚠️ +1.1s
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ⚠️ +8 B
_error.js gzip 66.3 kB 66.4 kB ⚠️ +89 B
hooks.html 3.81 kB 3.81 kB ⚠️ +3 B
hooks.html gzip 978 B 979 B ⚠️ +1 B
index.js 248 kB 248 kB ⚠️ +8 B
index.js gzip 66.6 kB 66.8 kB ⚠️ +140 B
link.js 256 kB 256 kB ⚠️ +8 B
link.js gzip 68.8 kB 68.9 kB ⚠️ +93 B
routerDirect.js 249 kB 249 kB ⚠️ +8 B
routerDirect.js gzip 66.8 kB 66.8 kB -70 B
withRouter.js 249 kB 249 kB ⚠️ +8 B
withRouter.js gzip 66.6 kB 66.7 kB ⚠️ +149 B
Overall change ⚠️ +43 B

@borekb
Copy link
Contributor Author

borekb commented Aug 22, 2019

@lfades The README is now much shorter (actually shorter than it was originally).

So to sum up this PR at this point:

  • now.json routing was fixed.
  • It's shown how to run an app separately, on plain next dev. Dynamic assetPrefix is the key.
  • It's shown how to handle /static assets from a zoned app.

@borekb borekb mentioned this pull request Aug 22, 2019
Merged
Timer
Timer requested changes Aug 22, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should work for this example.

examples/with-zones/now.json Outdated Show resolved Hide resolved
examples/with-zones/now.json Outdated Show resolved Hide resolved
examples/with-zones/now.json Outdated Show resolved Hide resolved
examples/with-zones/now.json Outdated Show resolved Hide resolved
@borekb @Timer
Use continue: true in now.json
24bf377 
Applies suggestions from code review.

Co-Authored-By: Joe Haddad <timer150@gmail.com>
@borekb
Copy link
Contributor Author

borekb commented Aug 22, 2019

@Timer I applied your suggestions in 24bf377. This is what I now see with now dev:

Screenshot 2019-08-22 at 17 55 47

Screenshot 2019-08-22 at 17 56 21

Cloud deployment is partially working:

https://with-zones-ll61kzche.now.sh/

Screenshot 2019-08-22 at 17 57 38

Screenshot 2019-08-22 at 17 57 51

Screenshot 2019-08-22 at 17 59 01

@ijjk
Copy link
Member

ijjk commented Aug 22, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.5s 24.1s ⚠️ +632ms
nodeModulesSize 41.2 MB 41.2 MB -902 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ⚠️ +1 B
main-HASH.js gzip 6.62 kB 6.63 kB ⚠️ +1 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ⚠️ +1 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ⚠️ +1 B
main-HASH.module.js gzip 6.36 kB 6.36 kB ⚠️ +1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ⚠️ +1 B
Client Pages Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB -1 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 434 B 433 B -1 B
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change -1 B
Client Pages Modern Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 866 B 867 B ⚠️ +1 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 805 B 804 B -1 B
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 430 B 429 B -1 B
withRouter.module.js gzip 293 B 293 B ✓
Overall change -1 B
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
link 3.75 kB 3.75 kB ✓
link gzip 963 B 964 B ⚠️ +1 B
index 3.69 kB 3.69 kB ✓
index gzip 954 B 955 B ⚠️ +1 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 950 B 950 B ✓
Overall change ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.9s 25.3s -526ms
nodeModulesSize 41.2 MB 41.2 MB -902 B
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.4 kB ⚠️ +111 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 977 B 978 B ⚠️ +1 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.5 kB -44 B
link.js 256 kB 256 kB ✓
link.js gzip 68.8 kB 68.9 kB ⚠️ +99 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.8 kB 66.7 kB -106 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.6 kB 66.7 kB ⚠️ +60 B
Overall change ✓

@Timer
Copy link
Member

Timer commented Aug 23, 2019 •
edited
Loading

@borekb now dev is broken -- only next dev and now (production) matter for correctness here.

See the now dev issue: vercel/vercel#2685

Timer
Timer requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the crux of the problem -- the blog app's page is actually called /blog instead of /index.

This seems like an unfortunately designed example 😄.

We will need a special route to handle /blog's _next and static folders.

@borekb
Copy link
Contributor Author

borekb commented Aug 25, 2019

now dev is broken -- only next dev and now (production) matter for correctness here. See the now dev issue: vercel/vercel#2685

Ah, thanks, that explains a lot!

I see the crux of the problem -- the blog app's page is actually called /blog instead of /index. This seems like an unfortunately designed example 😄.

Sorry, I'm not sure what you're referring to. Is somehow pages/blog.js vs. pages/blog/index.js a problem in the blog app?

We will need a special route to handle /blog's _next and static folders.

Ok, I'll add it back and see how it works.

@borekb
Copy link
Contributor Author

borekb commented Aug 25, 2019

🎉 with the _next & static routing rule added in 875a898, the multi-zones deployment works fine:

https://with-zones-rarjvagao.now.sh/

now dev is broken, as expected:

Screenshot 2019-08-25 at 20 14 39

@ijjk
Copy link
Member

ijjk commented Aug 25, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.1s 23.2s ⚠️ +88ms
nodeModulesSize 41.3 MB 41.2 MB -64.2 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB -28 B
main-HASH.js gzip 6.64 kB 6.63 kB -15 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change -28 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB -28 B
main-HASH.module.js gzip 6.37 kB 6.36 kB -14 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change -28 B
Client Pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.9 kB ⚠️ +67 B
_app.js gzip 884 B 908 B ⚠️ +24 B
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ⚠️ +67 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.79 kB ⚠️ +68 B
_app.module.js gzip 840 B 867 B ⚠️ +27 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ⚠️ +68 B
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓

Diffs

Diff for main-HASH.js 
@@ -289,7 +289,7 @@ var _interopRequireDefault = __webpack_require__("KI45");
 exports.__esModule = true;
 exports.render = render;
 exports.renderError = renderError;
-exports["default"] = exports.emitter = exports.ErrorComponent = exports.router = exports.dataManager = exports.version = void 0;
+exports["default"] = exports.emitter = exports.ErrorComponent = exports.router = exports.dataManager = void 0;
 
 var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
@@ -338,8 +338,6 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.0.5";
-exports.version = version;
 var props = data.props,
     err = data.err,
     page = data.page,
Diff for main-HASH.module.js 
@@ -361,7 +361,7 @@ var _interopRequireDefault = __webpack_require__("KI45");
 exports.__esModule = true;
 exports.render = render;
 exports.renderError = renderError;
-exports.default = exports.emitter = exports.ErrorComponent = exports.router = exports.dataManager = exports.version = void 0;
+exports.default = exports.emitter = exports.ErrorComponent = exports.router = exports.dataManager = void 0;
 
 var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
@@ -410,8 +410,6 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.0.5";
-exports.version = version;
 const {
   props,
   err,
Diff for _app.js 
@@ -118,7 +118,8 @@ function (_react$default$Compon) {
   }]);
 
   return App;
-}(_react["default"].Component);
+}(_react["default"].Component); // @deprecated noop for now until removal
+
 
 exports["default"] = App;
 App.childContextTypes = {
@@ -126,17 +127,15 @@ App.childContextTypes = {
 };
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
-var warnContainer;
-var warnUrl;
-
-if (false) {} // @deprecated noop for now until removal
-
 
 function Container(p) {
-  if (false) {}
   return p.children;
 }
 
+var warnUrl = (0, _utils.execOnce)(function () {
+  if (false) {}
+});
+
 function createUrl(router) {
   // This is to make sure we don't references the router object at call time
   var pathname = router.pathname,
@@ -144,40 +143,40 @@ function createUrl(router) {
       query = router.query;
   return {
     get query() {
-      if (false) {}
+      warnUrl();
       return query;
     },
 
     get pathname() {
-      if (false) {}
+      warnUrl();
       return pathname;
     },
 
     get asPath() {
-      if (false) {}
+      warnUrl();
       return asPath;
     },
 
     back: function back() {
-      if (false) {}
+      warnUrl();
       router.back();
     },
     push: function push(url, as) {
-      if (false) {}
+      warnUrl();
       return router.push(url, as);
     },
     pushTo: function pushTo(href, as) {
-      if (false) {}
+      warnUrl();
       var pushRoute = as ? href : '';
       var pushUrl = as || href;
       return router.push(pushRoute, pushUrl);
     },
     replace: function replace(url, as) {
-      if (false) {}
+      warnUrl();
       return router.replace(url, as);
     },
     replaceTo: function replaceTo(href, as) {
-      if (false) {}
+      warnUrl();
       var replaceRoute = as ? href : '';
       var replaceUrl = as || href;
       return router.replace(replaceRoute, replaceUrl);
Diff for _app.module.js 
@@ -121,7 +121,8 @@ class App extends _react.default.Component {
     }));
   }
 
-}
+} // @deprecated noop for now until removal
+
 
 exports.default = App;
 App.childContextTypes = {
@@ -129,17 +130,15 @@ App.childContextTypes = {
 };
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
-let warnContainer;
-let warnUrl;
-
-if (false) {} // @deprecated noop for now until removal
-
 
 function Container(p) {
-  if (false) {}
   return p.children;
 }
 
+const warnUrl = (0, _utils.execOnce)(() => {
+  if (false) {}
+});
+
 function createUrl(router) {
   // This is to make sure we don't references the router object at call time
   const {
@@ -149,40 +148,40 @@ function createUrl(router) {
   } = router;
   return {
     get query() {
-      if (false) {}
+      warnUrl();
       return query;
     },
 
     get pathname() {
-      if (false) {}
+      warnUrl();
       return pathname;
     },
 
     get asPath() {
-      if (false) {}
+      warnUrl();
       return asPath;
     },
 
     back: () => {
-      if (false) {}
+      warnUrl();
       router.back();
     },
     push: (url, as) => {
-      if (false) {}
+      warnUrl();
       return router.push(url, as);
     },
     pushTo: (href, as) => {
-      if (false) {}
+      warnUrl();
       const pushRoute = as ? href : '';
       const pushUrl = as || href;
       return router.push(pushRoute, pushUrl);
     },
     replace: (url, as) => {
-      if (false) {}
+      warnUrl();
       return router.replace(url, as);
     },
     replaceTo: (href, as) => {
-      if (false) {}
+      warnUrl();
       const replaceRoute = as ? href : '';
       const replaceUrl = as || href;
       return router.replace(replaceRoute, replaceUrl);
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 25.2s 25.2s -44ms
nodeModulesSize 41.3 MB 41.2 MB -64.2 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB -28 B
main-HASH.js gzip 6.64 kB 6.63 kB -15 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change -28 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB -28 B
main-HASH.module.js gzip 6.37 kB 6.36 kB -14 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change -28 B
Client Pages Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.9 kB ⚠️ +67 B
_app.js gzip 884 B 908 B ⚠️ +24 B
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ⚠️ +67 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.79 kB ⚠️ +68 B
_app.module.js gzip 840 B 867 B ⚠️ +27 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ⚠️ +68 B
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 247 kB 248 kB ⚠️ +262 B
_error.js gzip 66.4 kB 66.3 kB -162 B
hooks.html 3.81 kB 3.81 kB ⚠️ +2 B
hooks.html gzip 979 B 979 B ✓
index.js 248 kB 248 kB ⚠️ +262 B
index.js gzip 66.5 kB 66.6 kB ⚠️ +93 B
link.js 255 kB 256 kB ⚠️ +262 B
link.js gzip 68.8 kB 68.8 kB ⚠️ +14 B
routerDirect.js 249 kB 249 kB ⚠️ +262 B
routerDirect.js gzip 66.8 kB 66.8 kB ⚠️ +3 B
withRouter.js 248 kB 249 kB ⚠️ +262 B
withRouter.js gzip 66.8 kB 66.9 kB ⚠️ +20 B
Overall change ⚠️ +1.31 kB

@borekb
Copy link
Contributor Author

borekb commented Aug 25, 2019

For anyone interested, we also have a multi-zones setup which uses strictly sibling folders and the now.json config that works for us is as follows:

{
  "builds": [
    { "src": "apps/one/next.config.js", "use": "@now/next" },
    { "src": "apps/two/next.config.js", "use": "@now/next" }
  ],
  "routes": [
    { "src": "/app1/(_next|static)(.*)", "dest": "apps/one/$1$2" },
    { "src": "/app1(.*)", "dest": "apps/one/one$1" },
    { "src": "/app2/(_next|static)(.*)", "dest": "apps/two/$1$2" },
    { "src": "/app2(.*)", "dest": "apps/two/two$1" }
  ],
  "build": {
    "env": {
      "BUILDING_FOR_NOW": "true"
    }
  }
}

There is no continue: true (the significance of which I don't fully understand I have to admit) but the above seems to be working fine with both now and now dev.

@ijjk
Copy link
Member

ijjk commented Aug 25, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 20.1s 20.2s ⚠️ +85ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
index.html 3.7 kB 3.69 kB -2 B
index.html gzip 958 B 953 B -5 B
link.html 3.75 kB 3.74 kB -2 B
link.html gzip 966 B 961 B -5 B
withRouter.html 3.75 kB 3.75 kB -2 B
withRouter.html gzip 953 B 948 B -5 B
Overall change -6 B

Diffs

Diff for index.html 
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/index.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"btjN4CrEKxUxF5Mhbpa0D"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"IAgyzV5W21lhQHyNNXFf7"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/ZCluLHxOaECvPyb5sqwgxevgS+o=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/0+IMmkXYak4umZF9hSGywINFmLw=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/link.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"btjN4CrEKxUxF5Mhbpa0D"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"IAgyzV5W21lhQHyNNXFf7"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/ZCluLHxOaECvPyb5sqwgxevgS+o=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/0+IMmkXYak4umZF9hSGywINFmLw=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"btjN4CrEKxUxF5Mhbpa0D"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"IAgyzV5W21lhQHyNNXFf7"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/IAgyzV5W21lhQHyNNXFf7/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/ZCluLHxOaECvPyb5sqwgxevgS+o=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/0+IMmkXYak4umZF9hSGywINFmLw=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0XGiuwCN9U1PSMJrFXft9d6wwyc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/VMLrjJnR0y81nmhkOCGtnQh4nas=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/btjN4CrEKxUxF5Mhbpa0D/_buildManifest.module.js"
+        <script src="/_next/static/IAgyzV5W21lhQHyNNXFf7/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 21.3s 22s ⚠️ +708ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 247 kB 247 kB ⚠️ +10 B
_error.js gzip 66.4 kB 66.3 kB -108 B
hooks.html 3.81 kB 3.81 kB ⚠️ +2 B
hooks.html gzip 979 B 979 B ✓
index.js 248 kB 248 kB ⚠️ +10 B
index.js gzip 66.7 kB 66.6 kB -73 B
link.js 255 kB 255 kB ⚠️ +10 B
link.js gzip 68.9 kB 68.9 kB -4 B
routerDirect.js 249 kB 249 kB ⚠️ +10 B
routerDirect.js gzip 66.7 kB 66.8 kB ⚠️ +84 B
withRouter.js 248 kB 248 kB ⚠️ +10 B
withRouter.js gzip 66.6 kB 66.7 kB ⚠️ +179 B
Overall change ⚠️ +52 B

Timer
Timer requested changes Aug 26, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy we got this working! Just a few tweaks.

examples/with-zones/README.md Outdated Show resolved Hide resolved
examples/with-zones/README.md Outdated Show resolved Hide resolved
examples/with-zones/now.json Outdated Show resolved Hide resolved
@borekb @Timer
Update README of with-zones example slightly
2102c95 
Applies suggestions from code review.

Co-Authored-By: Joe Haddad <timer150@gmail.com>
@ijjk
Copy link
Member

ijjk commented Aug 27, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 22.6s 22.1s -498ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes
zeit/next.js canary borekb/next.js with-zones-example-update Change
index.html 3.7 kB 3.7 kB ✓
index.html gzip 958 B 956 B -2 B
link.html 3.75 kB 3.75 kB ✓
link.html gzip 966 B 965 B -1 B
withRouter.html 3.75 kB 3.75 kB ✓
withRouter.html gzip 953 B 952 B -1 B
Overall change ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.7s 25s ⚠️ +1.3s
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 247 kB 247 kB -8 B
_error.js gzip 66.4 kB 66.3 kB -65 B
hooks.html 3.81 kB 3.81 kB -3 B
hooks.html gzip 981 B 980 B -1 B
index.js 248 kB 248 kB -8 B
index.js gzip 66.6 kB 66.7 kB ⚠️ +93 B
link.js 255 kB 255 kB -8 B
link.js gzip 68.7 kB 68.8 kB ⚠️ +110 B
routerDirect.js 249 kB 249 kB -8 B
routerDirect.js gzip 66.7 kB 66.7 kB ⚠️ +63 B
withRouter.js 248 kB 248 kB -8 B
withRouter.js gzip 66.6 kB 66.7 kB ⚠️ +186 B
Overall change -43 B

@borekb @Timer
Remove unnecessary "dest" from now.json
9859821 
Co-Authored-By: Joe Haddad <timer150@gmail.com>
@ijjk
Copy link
Member

ijjk commented Aug 27, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 23.1s 23.2s ⚠️ +74ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes
zeit/next.js canary borekb/next.js with-zones-example-update Change
index.html 3.7 kB 3.7 kB ✓
index.html gzip 957 B 956 B -1 B
link.html 3.75 kB 3.75 kB ✓
link.html gzip 964 B 964 B ✓
withRouter.html 3.75 kB 3.75 kB ✓
withRouter.html gzip 952 B 951 B -1 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 24.4s 24.9s ⚠️ +577ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.2 kB 66.4 kB ⚠️ +157 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 984 B 981 B -3 B
index.js 248 kB 248 kB ✓
index.js gzip 66.5 kB 66.8 kB ⚠️ +268 B
link.js 255 kB 255 kB ✓
link.js gzip 68.7 kB 68.7 kB -33 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.9 kB 66.7 kB -192 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.9 kB 66.6 kB -230 B
Overall change ✓

@borekb
Copy link
Contributor Author

borekb commented Aug 27, 2019

Suggested edits committed, PR description updated, the PR is ready for review. Thanks a lot for helping with this, @Timer!

@ijjk
Copy link
Member

ijjk commented Aug 27, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 24.2s 24.1s -62ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary borekb/next.js with-zones-example-update Change
index.html 3.7 kB 3.7 kB -1 B
index.html gzip 955 B 954 B -1 B
link.html 3.75 kB 3.74 kB -1 B
link.html gzip 963 B 962 B -1 B
withRouter.html 3.75 kB 3.75 kB -1 B
withRouter.html gzip 950 B 949 B -1 B
Overall change -3 B

Diffs

Diff for index.html 
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/index.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"fqWqEIeskASYJsDDStzlv"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"fRmuVzmPTMkG6nTYWpIvj"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/jcr82aS7Im6o9hjPPoZ7d1S++c=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/Yh7b0bCts0r+lkU6egZldDuykg=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/link.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"fqWqEIeskASYJsDDStzlv"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"fRmuVzmPTMkG6nTYWpIvj"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/jcr82aS7Im6o9hjPPoZ7d1S++c=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/Yh7b0bCts0r+lkU6egZldDuykg=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"fqWqEIeskASYJsDDStzlv"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"fRmuVzmPTMkG6nTYWpIvj"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/fqWqEIeskASYJsDDStzlv/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/jcr82aS7Im6o9hjPPoZ7d1S++c=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/Yh7b0bCts0r+lkU6egZldDuykg=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/iR2OqHyscLsCfT09W4xgf1njTSU=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/qsJu4Dw6NhRsGBzaeCAzlgUY64Q=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/fqWqEIeskASYJsDDStzlv/_buildManifest.module.js"
+        <script src="/_next/static/fRmuVzmPTMkG6nTYWpIvj/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary borekb/next.js with-zones-example-update Change
buildDuration 26.1s 26.5s ⚠️ +398ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary borekb/next.js with-zones-example-update Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary borekb/next.js with-zones-example-update Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary borekb/next.js with-zones-example-update Change
_error.js 247 kB 247 kB ⚠️ +8 B
_error.js gzip 66.5 kB 66.3 kB -121 B
hooks.html 3.81 kB 3.81 kB ⚠️ +3 B
hooks.html gzip 981 B 982 B ⚠️ +1 B
index.js 248 kB 248 kB ⚠️ +3 B
index.js gzip 66.6 kB 66.6 kB ⚠️ +24 B
link.js 255 kB 255 kB ⚠️ +3 B
link.js gzip 68.9 kB 68.7 kB -134 B
routerDirect.js 249 kB 249 kB ⚠️ +3 B
routerDirect.js gzip 66.7 kB 66.7 kB -67 B
withRouter.js 248 kB 248 kB ⚠️ +3 B
withRouter.js gzip 66.7 kB 66.7 kB -9 B
Overall change ⚠️ +23 B

@Timer Timer added this to the 9.0.6 milestone Aug 27, 2019
@Timer Timer added ready to land examples Issue/PR related to examples labels Aug 27, 2019
@Timer Timer merged commit 4292a9a into vercel:canary Aug 27, 2019
@borekb borekb deleted the with-zones-example-update branch September 19, 2019 11:03
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades lfades left review comments

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@borekb @ijjk @Timer @lfades