Tweaks and test for library chunks fixes #8482

atcastle · 2019-08-22T23:07:05Z

This is a test to go with #8450 and addresses a comment on that PR.

…js into fix-granular-chunks-regex

…ks-regex

ijjk · 2019-08-22T23:14:45Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	23s	23.1s	⚠️ +119ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.36 kB	6.36 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			✓

Client Pages

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
link	3.75 kB	3.75 kB	✓
link gzip	961 B	960 B	-1 B
index	3.69 kB	3.69 kB	✓
index gzip	954 B	952 B	-2 B
withRouter	3.75 kB	3.75 kB	✓
withRouter gzip	948 B	947 B	-1 B
Overall change			✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	25.7s	25.6s	-187ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.36 kB	6.36 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			✓

Client Pages

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_error.js	247 kB	247 kB	-8 B
_error.js gzip	66.2 kB	66.2 kB	⚠️ +48 B
hooks.html	3.81 kB	3.81 kB	-3 B
hooks.html gzip	978 B	974 B	-4 B
index.js	248 kB	248 kB	-3 B
index.js gzip	66.6 kB	66.6 kB	-27 B
link.js	255 kB	255 kB	-3 B
link.js gzip	68.8 kB	68.9 kB	⚠️ +78 B
routerDirect.js	249 kB	249 kB	-3 B
routerDirect.js gzip	66.7 kB	66.6 kB	-105 B
withRouter.js	248 kB	248 kB	-3 B
withRouter.js gzip	66.7 kB	66.6 kB	-128 B
Overall change			-23 B

ijjk · 2019-08-22T23:50:36Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	23.8s	23.9s	⚠️ +171ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	-1 B
main-HASH.js gzip	6.63 kB	6.62 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	-1 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
link	3.74 kB	3.74 kB	⚠️ +2 B
link gzip	963 B	964 B	⚠️ +1 B
index	3.69 kB	3.69 kB	⚠️ +2 B
index gzip	956 B	957 B	⚠️ +1 B
withRouter	3.75 kB	3.75 kB	⚠️ +2 B
withRouter gzip	951 B	951 B	✓
Overall change			⚠️ +6 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	26.4s	25.7s	-674ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	-1 B
main-HASH.js gzip	6.63 kB	6.62 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	-1 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_error.js	247 kB	247 kB	-8 B
_error.js gzip	66.4 kB	66.3 kB	-124 B
hooks.html	3.81 kB	3.81 kB	-3 B
hooks.html gzip	977 B	979 B	⚠️ +2 B
index.js	248 kB	248 kB	-8 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +14 B
link.js	255 kB	255 kB	-8 B
link.js gzip	68.9 kB	68.8 kB	-45 B
routerDirect.js	249 kB	249 kB	-8 B
routerDirect.js gzip	66.8 kB	66.7 kB	-173 B
withRouter.js	248 kB	248 kB	-8 B
withRouter.js gzip	66.8 kB	66.6 kB	-220 B
Overall change			-43 B

atcastle · 2019-08-23T00:00:58Z

test/integration/chunking/test/index.test.js

@@ -37,12 +40,6 @@ describe('Chunking', () => {
    expect(existsChunkNamed('framework')).toBe(true)
  })

-  it('should create a library chunk for lodash', () => {


Removing this test as we're no longer naming library chunks in a predictable way. I could use the generated hash, here, but I'm afraid that would make this test too fragile.

Timer

Excellent -- this greatly simplifies the logic!

test/integration/chunking-minimal/test/index.test.js

ijjk · 2019-08-23T14:17:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	23.9s	24.1s	⚠️ +165ms
nodeModulesSize	41.2 MB	41.2 MB	-1.73 kB

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	-1 B
main-HASH.js gzip	6.63 kB	6.62 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	-1 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
link	3.75 kB	3.74 kB	-3 B
link gzip	960 B	963 B	⚠️ +3 B
index	3.69 kB	3.69 kB	-3 B
index gzip	952 B	956 B	⚠️ +4 B
withRouter	3.75 kB	3.75 kB	-3 B
withRouter gzip	947 B	951 B	⚠️ +4 B
Overall change			-9 B

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	26.9s	26.5s	-376ms
nodeModulesSize	41.2 MB	41.2 MB	-1.73 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.36 kB	6.36 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			✓

Client Pages

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_error.js	247 kB	247 kB	⚠️ +8 B
_error.js gzip	66.4 kB	66.2 kB	-137 B
hooks.html	3.81 kB	3.81 kB	⚠️ +3 B
hooks.html gzip	978 B	982 B	⚠️ +4 B
index.js	248 kB	248 kB	⚠️ +8 B
index.js gzip	66.7 kB	66.7 kB	-66 B
link.js	255 kB	255 kB	⚠️ +8 B
link.js gzip	68.8 kB	68.8 kB	-75 B
routerDirect.js	249 kB	249 kB	⚠️ +8 B
routerDirect.js gzip	66.7 kB	66.9 kB	⚠️ +181 B
withRouter.js	248 kB	248 kB	⚠️ +8 B
withRouter.js gzip	66.7 kB	66.7 kB	-18 B
Overall change			⚠️ +43 B

ijjk · 2019-08-23T14:21:23Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	22.2s	21.7s	-594ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.36 kB	6.36 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			✓

Client Pages

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
link	3.75 kB	3.74 kB	-1 B
link gzip	966 B	963 B	-3 B
index	3.69 kB	3.69 kB	-1 B
index gzip	958 B	955 B	-3 B
withRouter	3.75 kB	3.75 kB	-1 B
withRouter gzip	952 B	950 B	-2 B
Overall change			-3 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
buildDuration	24.3s	23.9s	-325ms
nodeModulesSize	41.2 MB	41.2 MB	-868 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.js	18.1 kB	18.1 kB	-1 B
main-HASH.js gzip	6.63 kB	6.62 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
main-HASH.module.js	16.5 kB	16.5 kB	-1 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	atcastle/next.js fix-granular-chunks-regex	Change
_error.js	247 kB	247 kB	⚠️ +8 B
_error.js gzip	66.2 kB	66.4 kB	⚠️ +169 B
hooks.html	3.81 kB	3.81 kB	⚠️ +3 B
hooks.html gzip	972 B	981 B	⚠️ +9 B
index.js	248 kB	248 kB	⚠️ +8 B
index.js gzip	66.5 kB	66.6 kB	⚠️ +136 B
link.js	255 kB	255 kB	⚠️ +8 B
link.js gzip	68.8 kB	68.8 kB	⚠️ +23 B
routerDirect.js	249 kB	249 kB	⚠️ +8 B
routerDirect.js gzip	66.7 kB	66.6 kB	-94 B
withRouter.js	248 kB	248 kB	⚠️ +8 B
withRouter.js gzip	66.7 kB	66.7 kB	-8 B
Overall change			⚠️ +43 B

atcastle and others added 10 commits August 20, 2019 10:47

Adjust lib chunk naming algorithm and prevent duplicate react-dom

bc31876

Remove alias for react-dom and update separator replacement logic

4381c67

Add comment to webpack-config

f7802a2

Merge branch 'canary' into fix-granular-chunks-regex

f94e75d

Add integration test for react-dom duplication

2ba0103

Switch to using hash for lib chunk names

8f68adb

Merge branch 'fix-granular-chunks-regex' of github.com:atcastle/next.…

9778b25

…js into fix-granular-chunks-regex

Merge remote-tracking branch 'upstream/canary' into fix-granular-chun…

91ad04f

…ks-regex

remove extra file from PR

bf71a79

Remove another extraneous change

286c210

atcastle requested review from ijjk, lfades, Timer and timneutkens as code owners August 22, 2019 23:07

Remove test based on lib chunk name

de67ae9

atcastle commented Aug 23, 2019

View reviewed changes

Timer approved these changes Aug 23, 2019

View reviewed changes

test/integration/chunking-minimal/test/index.test.js Outdated Show resolved Hide resolved

Update index.test.js

7d19140

Timer added the ready to land label Aug 23, 2019

Timer added this to the 9.0.5 milestone Aug 23, 2019

Merge branch 'canary' into fix-granular-chunks-regex

cd40b80

Timer merged commit 3970a26 into vercel:canary Aug 23, 2019

ijjk mentioned this pull request Aug 24, 2019

Fix backslashes in stats causing tests to fail on windows #8505

Merged

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweaks and test for library chunks fixes #8482

Tweaks and test for library chunks fixes #8482

atcastle commented Aug 22, 2019

ijjk commented Aug 22, 2019

ijjk commented Aug 22, 2019

Diffs

atcastle Aug 23, 2019

Timer left a comment

ijjk commented Aug 23, 2019

ijjk commented Aug 23, 2019

Diffs

Tweaks and test for library chunks fixes #8482

Tweaks and test for library chunks fixes #8482

Conversation

atcastle commented Aug 22, 2019

ijjk commented Aug 22, 2019

Stats from current PR

ijjk commented Aug 22, 2019

Stats from current PR

Diffs

atcastle Aug 23, 2019

Choose a reason for hiding this comment

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Aug 23, 2019

Stats from current PR

ijjk commented Aug 23, 2019

Stats from current PR

Diffs