Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resetting console[method] for spinners #8995

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Update resetting console[method] for spinners #8995

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d60da5
Update resetting log for spinners
ijjk Oct 8, 2019
430da9e
Merge remote-tracking branch 'upstream/canary' into update/spinner
ijjk Oct 8, 2019
3fd7299
Merge remote-tracking branch 'upstream/canary' into update/spinner
ijjk Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/next/build/spinner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export default function createSpinner(
...options,
}).start()

// Add capturing of console.log/warn/error to allow pausing
// the spinner before logging and then restarting spinner after
const origLog = console.log
const origWarn = console.warn
const origError = console.error
Expand All @@ -39,6 +41,8 @@ export default function createSpinner(

const resetLog = () => {
console.log = origLog
console.warn = origWarn
console.error = origError
}
spinner.stop = (): ora.Ora => {
origStop()
Expand Down