Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Enable AMP Tests #9162

Merged
merged 10 commits into from
Oct 23, 2019
Merged

Re-Enable AMP Tests #9162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f908c7
Reenable AMP Tests
Timer Oct 22, 2019
aefa80e
Merge branch 'canary' into enable-amp-tests
Timer Oct 22, 2019
5dc455e
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
e511e56
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
ccffb1f
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
cfb3032
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
3e0cba1
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
82496bc
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
637c2f0
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
259194d
Merge branch 'canary' into enable-amp-tests
Timer Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/amp-export-validation/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const nextConfig = new File(join(appDir, 'next.config.js'))

let buildOutput

xdescribe('AMP Validation on Export', () => {
describe('AMP Validation on Export', () => {
beforeAll(async () => {
const { stdout = '', stderr = '' } = await nextBuild(appDir, [], {
stdout: true,
Expand Down
2 changes: 1 addition & 1 deletion test/integration/amphtml-fragment-style/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ let appPort
let server
let app

xdescribe('AMP Fragment Styles', () => {
describe('AMP Fragment Styles', () => {
beforeAll(async () => {
await nextBuild(appDir)
app = nextServer({
Expand Down
2 changes: 1 addition & 1 deletion test/integration/amphtml/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5

const context = {}

xdescribe('AMP Usage', () => {
describe('AMP Usage', () => {
beforeAll(async () => {
await nextBuild(appDir)
app = nextServer({
Expand Down
4 changes: 2 additions & 2 deletions test/integration/styled-jsx-module/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function runTests () {
expect(color).toMatch('0, 255, 255')
})

xit('should render styles during CSR (AMP)', async () => {
it('should render styles during CSR (AMP)', async () => {
const browser = await webdriver(appPort, '/amp')
const color = await browser.eval(
`getComputedStyle(document.querySelector('button')).color`
Expand All @@ -41,7 +41,7 @@ function runTests () {
expect(html).toMatch(/color:.*?cyan/)
})

xit('should render styles during SSR (AMP)', async () => {
it('should render styles during SSR (AMP)', async () => {
const html = await renderViaHTTP(appPort, '/amp')
expect(html).toMatch(/color:.*?cyan/)
})
Expand Down