Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27.8 requires node ^18.17.0 || >=20.5.0 but nft intends to support node>=16 #457

Closed
serhalp opened this issue Dec 13, 2024 · 4 comments · Fixed by #460
Closed

0.27.8 requires node ^18.17.0 || >=20.5.0 but nft intends to support node>=16 #457

serhalp opened this issue Dec 13, 2024 · 4 comments · Fixed by #460

Comments

@serhalp
Copy link

serhalp commented Dec 13, 2024

👋🏼 Hi folks!

This PR to upgrade node-pre-gyp (released in 0.27.8) indirectly bumped a transitive dependency nopt from 5.0.0 to 8.0.0.

and nopt@8.0.0 requires node ^18.17.0 || >=20.5.0.

However, @vercel/nft has package.json#engines#node of >=16:

nft/package.json

Lines 145 to 147 in 7fbb559

"engines": {
"node": ">=16"
},

TL;DR: nft intends to support node 16+ but no longer supports 16 to 18.16.0

I realize since nft is still on 0.x it can introduce breaking changes at any time, but I'm guessing this wasn't intentional! If it is, could we update the engines.node and note this in the release notes?

Thanks! Happy to open a PR if you all know what direction you want to take.

@styfle
Copy link
Member

styfle commented Dec 13, 2024

engines.node should be updated since node@16 has reached EOL a year ago

https://nodejs.org/en/blog/announcements/nodejs16-eol

@serhalp
Copy link
Author

serhalp commented Dec 13, 2024

@styfle would you accept a PR to revert this change in another patch and a PR to update engines.node to >=18 (new minor? 0.x semantics are weird...)

serhalp added a commit to netlify/build that referenced this issue Dec 14, 2024
See vercel/nft#457

Co-authored-by: Mateusz Bocian <mrstork@users.noreply.github.com>
@styfle
Copy link
Member

styfle commented Jan 2, 2025

Sorry about the delay.

I checked when we dropped support for node@16 and it was a year ago in PR #374

Since that bumped the semver version correctly, I think we can make a new PR with a patch to bump engines to match that.

serhalp added a commit to serhalp/nft that referenced this issue Jan 2, 2025
As discussed [here](vercel#457 (comment)), node 16 support was already dropped in 0.26.0, but `package.json#engines#node` was not updated.
@serhalp
Copy link
Author

serhalp commented Jan 2, 2025

That makes sense, thanks! Here's a PR: #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants