Change source code to TypeScript #133
Conversation
src/resolve-dependency.ts
Outdated
| if (typeof exports === 'string' || | ||
| typeof exports === 'object' && !Array.isArray(exports) && Object.keys(exports).length && Object.keys(exports)[0][0] !== '.') | ||
| exports = { '.' : exports }; | ||
| function resolveExportsTarget (pkgPath: string, exp: string | { [key: string]: string }, subpath: string, job: Job, cjsResolve: boolean): string | undefined { |
There was a problem hiding this comment.
I noticed that getExportsTarget() handles the exports: null case however this resolveExportsTarget() function does not. Should we also handle exports: null here?
There was a problem hiding this comment.
Yes on 117 we should probably have a null check too for consistency.
There was a problem hiding this comment.
What should happen for null on line 117?
return null?- assign
exports = { '.' : null }? - assign
exports = null? - something else?
There was a problem hiding this comment.
Actually exports can never be null or undefined here as it is guarded in all calls.
There was a problem hiding this comment.
Good point, I added a PkgCfg and Exports type so we can confirm all cases are covered, thanks!
src/resolve-dependency.ts
Outdated
| @@ -183,5 +200,5 @@ function resolvePackage (name, parent, job, cjsResolve) { | |||
| return resolveFile(pathTarget, parent, job) || resolveDir(pathTarget, parent, job); | |||
There was a problem hiding this comment.
This path should have || throwNotFound on the fallback.
There was a problem hiding this comment.
Ah ha, this is the missing piece! I pushed a change which makes sure resolveDependency(): string | string[] so we never return undefined anymore
I found a few bugs when changing the source code to TypeScript.
I'll need some feedback from @guybedford to decide how to proceed in some cases, see comments below.