Fix path sep and run all unit tests against root

src/node-file-trace.ts

@@ -232,7 +232,7 @@ export class Job {
     // keep backtracking for realpath, emitting folder symlinks within base
     if (!inPath(path, this.base))
       return path;
-    return this.realpath(dirname(path), parent, seen) + sep + basename(path);
+    return join(this.realpath(dirname(path), parent, seen), basename(path));
   }
 
   emitFile (path: string, reason: string, parent?: string, isRealpath = false) {

test/unit.test.js

@@ -5,15 +5,20 @@ const { nodeFileTrace } = require('../out/node-file-trace');
 global._unit = true;
 
 const skipOnWindows = ['yarn-workspaces', 'yarn-workspaces-base-root', 'yarn-workspace-esm', 'asset-symlink', 'require-symlink'];
-const setBaseToRoot = ['yarn-workspaces-base-root'];
+const unitTestDirs = fs.readdirSync(join(__dirname, 'unit'));
+const unitTests = [
+  ...unitTestDirs.map(testName => ({testName, isRoot: false})),
+  ...unitTestDirs.map(testName => ({testName, isRoot: true})),
+];
 
-for (const unitTest of fs.readdirSync(join(__dirname, 'unit'))) {
-  if (process.platform === 'win32' && skipOnWindows.includes(unitTest)) {
-    console.log('skipping symlink test on Windows: ' + unitTest);
+for (const { testName, isRoot } of unitTests) {
+  const testSuffix = `${testName} from ${isRoot ? 'root' : 'cwd'}`;
+  if (process.platform === 'win32' && (isRoot || skipOnWindows.includes(testName))) {
+    console.log(`Skipping unit test on Windows: ${testSuffix}`);
     continue;
-  }
-  it(`should correctly trace ${unitTest}`, async () => {
-    const unitPath = join(__dirname, 'unit', unitTest);
+  };
+  it(`should correctly trace ${testSuffix}`, async () => {
+    const unitPath = join(__dirname, 'unit', testName);
 
     // We mock readFile because when node-file-trace is integrated into @now/node
     // this is the hook that triggers TypeScript compilation. So if this doesn't
@@ -25,26 +30,25 @@ for (const unitTest of fs.readdirSync(join(__dirname, 'unit'))) {
 
     let inputFileName = "input.js";
 
-    if (unitTest === "tsx-input") {
+    if (testName === "tsx-input") {
       inputFileName = "input.tsx";
     }
 
-    const isRoot = setBaseToRoot.includes(unitTest);
-
     const { fileList, reasons } = await nodeFileTrace([join(unitPath, inputFileName)], {
       base: isRoot ? '/' : `${__dirname}/../`,
       processCwd: unitPath,
       paths: {
-        dep: 'test/unit/esm-paths/esm-dep.js',
-        'dep/': 'test/unit/esm-paths-trailer/'
+        dep: `${__dirname}/../test/unit/esm-paths/esm-dep.js`,
+        'dep/': `${__dirname}/../test/unit/esm-paths-trailer/`
       },
-      exportsOnly: unitTest.startsWith('exports-only'),
+      exportsOnly: testName.startsWith('exports-only'),
       ts: true,
       log: true,
       // disable analysis for basic-analysis unit tests
-      analysis: !unitTest.startsWith('basic-analysis'),
+      analysis: !testName.startsWith('basic-analysis'),
       mixedModules: true,
-      ignore: '**/actual.js',
+      // Ignore unit test output "actual.js", and ignore GitHub Actions preinstalled packages
+      ignore: (str) => str.endsWith('/actual.js') || str.startsWith('usr/local'),
       readFile: readFileMock
     });
     let expected;
@@ -73,7 +77,7 @@ for (const unitTest of fs.readdirSync(join(__dirname, 'unit'))) {
       throw e;
     }
 
-    if (unitTest === "tsx-input") {
+    if (testName === "tsx-input") {
       expect(readFileMock.mock.calls.length).toBe(2);
     }
   });