Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tsx resolution tracing #17

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Support tsx resolution tracing #17

merged 1 commit into from
Jul 13, 2019

Conversation

guybedford
Copy link
Contributor

This adds support for .tsx file resolution tracing.

We could also consider adding a jsx: true option similarly if this is desired for now-node.

This should resolve the issue seen in #10, although there may also be a resolver component of that issue in the now/node integration there too.

@guybedford guybedford requested a review from styfle as a code owner July 12, 2019 22:21
@codecov-io
Copy link

Codecov Report

Merging #17 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   89.46%   89.47%   +0.01%     
==========================================
  Files          10       10              
  Lines         940      941       +1     
==========================================
+ Hits          841      842       +1     
  Misses         99       99
Impacted Files Coverage Δ
src/resolve-dependency.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6099031...c8af8e3. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit f83b328 into master Jul 13, 2019
@styfle styfle deleted the tsx branch July 13, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants