Emit symlinks directly #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
+ Coverage 89.51% 89.6% +0.09%
=========================================
Files 10 10
Lines 944 972 +28
=========================================
+ Hits 845 871 +26
- Misses 99 101 +2
Continue to review full report at Codecov.
|
|
I think this is what @lucleray was talking about: Only emitting the symlink directory. I am testing with the PR and so far so good https://github.com/zeit/now-builders/pull/765 |
styfle
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an internal realpath routine, which then emits symlinks as direct references.
This way "virtual" files within symlinked folders will not ever be emitted - rather the symlink folder itself is emitted, and then the files are emitted at their realpath.
On the consumer side, a direct lstat applied to the
fileListcan determine if a file is a symlink, and in those cases emit the directory or file symlink as appropriate, but that is the only check needed.This should allow for a straightforward fix to zeit/now-builders#765.