major: Change reason type from string to array #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 80.62% 80.65% +0.02%
==========================================
Files 13 13
Lines 1461 1463 +2
Branches 543 544 +1
==========================================
+ Hits 1178 1180 +2
Misses 116 116
Partials 167 167
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
styfle
force-pushed
the
feature-add-reason-array
branch
from
9abb3cc to
1051ee6
Compare
ijjk
reviewed
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a scenario where a single file is both imported as a
dependencyand read as aassetfile so we must keep track of both usages in the Reason object.