Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle static eval for sequence expression (fix TS 4.4+) #289

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: handle static eval for sequence expression (fix TS 4.4+) #289

merged 1 commit into from
May 23, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented May 23, 2022

@styfle styfle requested a review from ijjk as a code owner May 23, 2022 15:40
@styfle styfle mentioned this pull request May 23, 2022
Closed
ijjk
ijjk approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@styfle styfle changed the title fix: handle static eval for sequence expression fix: handle static eval for sequence expression (fix TS 4.4+) May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #289 (78e3176) into main (fd36510) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   80.28%   80.33%   +0.05%     
==========================================
  Files          13       13              
  Lines        1486     1490       +4     
  Branches      555      556       +1     
==========================================
+ Hits         1193     1197       +4     
  Misses        122      122              
  Partials      171      171
Impacted Files Coverage Δ
src/utils/static-eval.ts 83.17% <100.00%> (+0.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@styfle styfle merged commit 60c5f2a into main May 23, 2022
@styfle styfle deleted the fix-ts-path branch May 23, 2022 15:57
@styfle styfle mentioned this pull request Jun 5, 2022
Merged
kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Jun 6, 2022
@styfle
[node] Skip TS compile for .d.ts assets (#7918)
9b08e72 
Fixes an issue where `.d.ts` assets were incorrectly being compiled after a fix to nft in vercel/nft#289

- [Repro Steps](https://github.com/cheapsteak/repro-vercel-cli-build-dts-error)
- [Incident](https://app.kintaba.com/incident/755531679765890512)
- [Slack](https://vercel.slack.com/archives/C03JNHA844R/p1654334373086879)

<img src="https://user-images.githubusercontent.com/229881/172055403-d2edfe1d-3a60-459f-bf40-506fea1d1ca4.png" height=500 />
@lobsterkatie lobsterkatie mentioned this pull request Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output from TypeScript 4.4+ no longer traceable
2 participants
@styfle @ijjk