Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow all file extension inputs (including .jsx) #294

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 9, 2022

This fixes an issue where a file input ending with .jsx was not traced properly.

Since we already fail gracefully for files that cannot be parsed, this PR removes the guard on all input file extensions.

@styfle styfle requested a review from ijjk as a code owner June 9, 2022 21:41
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #294 (3727a22) into main (e3f6b7a) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 3727a22 differs from pull request most recent head 16c91c5. Consider uploading reports for the commit 16c91c5 to get more accurate results

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   80.33%   80.44%   +0.10%     
==========================================
  Files          13       13              
  Lines        1490     1488       -2     
  Branches      556      555       -1     
==========================================
  Hits         1197     1197              
+ Misses        122      121       -1     
+ Partials      171      170       -1     
Impacted Files Coverage Δ
src/node-file-trace.ts 87.50% <100.00%> (+0.80%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@styfle styfle enabled auto-merge (squash) June 9, 2022 21:49
@styfle styfle merged commit 46631cb into main Jun 9, 2022
@styfle styfle deleted the fix-jsx-tracing branch June 9, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace entry files without extension
2 participants