demonstrate mjs file identified as esm, but handled as cjs #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
.mjs
file is traced, it adds allimport
intodeps
instead ofimports
. Later in the tracing, it treatsdeps
as CJS and it incorrectly resolves the default export for theplaywright-core
package.This regression was introduced by #362, but that PR does fix the issue of CJS files being resolved incorrectly.
I don't know the background, but it seems all
import
s, especially in.mjs
files, should go intoimports
, notdeps
.@styfle can you please advise?
Test failure: