Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add special case for geoip-lite #446

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: add special case for geoip-lite #446

merged 3 commits into from
Oct 22, 2024

Conversation

kongmoumou
Copy link
Contributor

Currently, nft can not handle data assets of geoip-lite package properly. Error message like below ⬇️

image

Test Code

const geoip = require('geoip-lite');

const ip = "207.97.227.239";
const geo = geoip.lookup(ip);

This PR adds essential data files as assets for geoip-lite in special-case to solve it.

@kongmoumou kongmoumou requested review from ijjk, styfle and a team as code owners October 22, 2024 13:27
@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/geoip-lite@1.4.10 environment, filesystem, network +18 166 MB bluesmoon

View full report↗︎

styfle
styfle approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We can merge this one but I think a better solution would be fixing the static analysis for the fallback here:

https://github.com/geoip-lite/node-geoip/blob/c788342dfce6d97244842622da6e4fa259f79742/lib/geoip.js#L13-L16

@styfle styfle changed the title fix: geoip lite integration fix: add special case for geoip-lite Oct 22, 2024
@styfle styfle merged commit b3d2da0 into vercel:main Oct 22, 2024
13 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.27.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@leonardoadame leonardoadame mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kongmoumou @styfle