Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma special case #9

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Prisma special case #9

merged 2 commits into from
Jul 11, 2019

Conversation

guybedford
Copy link
Contributor

This adds special case handling for the following code path in prisma which is currently non-analyzable:

const path = __importStar(__webpack_require__(589));
NodeEngine.defaultPrismaPath = path.join(__dirname + '/dist', '../prisma');

The root fix for analyzability would otherwise be based on two new features - webpack bundle analysis to trace __webpack_require__ IDs, and __importStar analysis, which are certainly possible, but would need to be justified.

@guybedford guybedford requested a review from styfle as a code owner July 11, 2019 02:43
@codecov-io
Copy link

Codecov Report

Merging #9 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   89.44%   89.46%   +0.02%     
==========================================
  Files          10       10              
  Lines         938      940       +2     
==========================================
+ Hits          839      841       +2     
  Misses         99       99
Impacted Files Coverage Δ
src/utils/special-cases.js 95.58% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db01fb9...4ffd62f. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 31118a9 into master Jul 11, 2019
@styfle styfle deleted the prisma branch July 11, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants