Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Squashed revert "allow to compress files in virtual file system (#1115)" #1199

Merged
merged 1 commit into from
May 31, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented May 31, 2021

This reverts commit 82ce625.
This reverts commit ea23196.
This reverts commit ea7d72b.

Apparently the compression feature needs more work.

I can confirm that this revert at least fixes const db = require('better-sqlite3')("test.sqlite");, mentioned in #1191 (comment).

Bug: #1191, #1192

This reverts commit 82ce625.
This reverts commit ea23196.
This reverts commit ea7d72b.

Bug: #1191, #1192
@jesec jesec merged commit 52ddf23 into master May 31, 2021
@jesec jesec deleted the pr/revert-compression branch May 31, 2021 16:32
@jesec
Copy link
Contributor Author

jesec commented May 31, 2021

@leerob We can release 5.2.2.

@erossignon
Copy link
Contributor

That's harsh ! Shall we fix root cause of #1191, #1192 instead ?

@jesec
Copy link
Contributor Author

jesec commented Jun 1, 2021

That's harsh ! Shall we fix root cause of #1191, #1192 instead ?

I understand. However, the bugs are there for a week. Since none of us dealt with the issue in time, the most logical and straightforward option is to fix a severe bug by reverting an optional feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants