This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
fix: do not overwrite temp .node files #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
paul-marechal
force-pushed
the
node-overwrite-fix
branch
from
ebdcb32
to
e84bed1
Compare
paul-marechal
changed the title
|
See #1492 . |
|
@jesec I know about #1492, and the issue happened because it used to check for the folder to exist, and I can anecdotally say that I also encountered the same issue in the past where the folder would exist but the This PR is different because it checks for the file's existence. |
robertsLando
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
@jesec The other PR you mentioned is for the first if case where the entire folder is copied
jesec
approved these changes
Mar 31, 2022
This can happen when two processes try to load the same .node file.
jesec
force-pushed
the
node-overwrite-fix
branch
from
e84bed1
to
d356c4c
Compare
|
Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when two processes try to load the same .node file.