Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better SSR methods #46

Merged
merged 9 commits into from
Dec 19, 2016
Merged

Better SSR methods #46

merged 9 commits into from
Dec 19, 2016

Conversation

rauchg
Copy link
Member

@rauchg rauchg commented Dec 19, 2016

Fixes #22

  • Adds styled-jsx/server
    • flush() (default) returns an array of React.Element for each <style>
    • flushToHTML returns an HTML string

Additionally

  • Both new methods include an id in the resulting <style> that the client rendering part can use to de-dupe.
  • The de-duping logic only checks the DOM once and works transparently, without manual initialization by the user

@nkzawa
Copy link
Contributor

nkzawa commented Dec 19, 2016

It looks we have to fix styles (CI is failing)

@nkzawa nkzawa merged commit 4f24669 into master Dec 19, 2016
@nkzawa nkzawa deleted the add/better-ssr branch December 19, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants