Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle jsx spread attribute with object expression #541

Merged

Conversation

doniyor2109
Copy link
Contributor

It should solve #539

Copy link
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Thank you for this PR and apologies if it took too long to reply

src/_utils.js Show resolved Hide resolved
test/fixtures/spread-operator.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last round of feedback and then I'll merge :) thanks for your patience!

src/_utils.js Outdated Show resolved Hide resolved
src/_utils.js Outdated Show resolved Hide resolved
src/_utils.js Outdated Show resolved Hide resolved
@giuseppeg giuseppeg merged commit 7743670 into vercel:master Feb 10, 2019
@giuseppeg
Copy link
Collaborator

@doniyor2109 amazing job! thank you

@subtleGradient
Copy link

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants