Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer dep declaration for react 18 with npm #788

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 13, 2022

x-ref: vercel/next-react-server-components#35

18.x.x seems to be treated as mismatch for react and react-dom with npm install, and then styled-jsx will be installed under node_modules/next/node_modules which leads to styled-jsx/style is not found.

yarn works fine

@huozhi huozhi requested a review from giuseppeg as a code owner March 13, 2022 18:24
@huozhi huozhi requested review from ijjk, shuding and styfle March 13, 2022 18:24
@huozhi huozhi merged commit 384d208 into main Mar 13, 2022
@huozhi huozhi deleted the fix-react-dep branch March 13, 2022 19:51
@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2022
x-ref: vercel/next-react-server-components#35
x-ref: vercel/styled-jsx#788

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants