Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use typeof window to detect browser #810

Merged
merged 2 commits into from
Sep 2, 2022
Merged

perf: use typeof window to detect browser #810

merged 2 commits into from
Sep 2, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 1, 2022 •
edited
Loading

Use typeof window condition to check runtime everywhere for future better tree-shaking purpose

@huozhi huozhi marked this pull request as ready for review September 1, 2022 23:43
@huozhi huozhi requested a review from ijjk as a code owner September 1, 2022 23:43
@huozhi huozhi changed the title perf: hoist the browser detection condition perf: use typeof window to detect browser Sep 1, 2022
@huozhi huozhi merged commit 2a31e73 into main Sep 2, 2022
@huozhi huozhi deleted the use-optimizable-condition branch September 2, 2022 00:30
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

🎉 This PR is included in version 5.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wainnyta wainnyta mentioned this pull request Jun 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huozhi @ijjk