Fix mutation types order (#2669)

vercel · Jun 15, 2023 · 8ffdc15 · 8ffdc15
1 parent c263f06
commit 8ffdc15
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/mutation/src/types.ts b/mutation/src/types.ts
@@ -49,7 +49,7 @@ export type SWRMutationConfiguration<
 }
 
 type RemoveUndefined<T> = T extends undefined ? never : T
-interface TriggerWithArgs<
+export interface TriggerWithArgs<
   Data = any,
   Error = any,
   SWRMutationKey extends Key = Key,
@@ -87,7 +87,7 @@ interface TriggerWithArgs<
   ): Promise<Data | undefined>
 }
 
-interface TriggerWithoutArgs<
+export interface TriggerWithoutArgs<
   Data = any,
   Error = any,
   SWRMutationKey extends Key = Key,
@@ -140,7 +140,7 @@ export interface SWRMutationResponse<
    * the fetcher, and override the options for the mutation hook.
    */
   trigger: [ExtraArg] extends [never]
-    ? TriggerWithoutArgs<Data, Error, ExtraArg, SWRMutationKey>
+    ? TriggerWithoutArgs<Data, Error, SWRMutationKey, ExtraArg>
     : TriggerWithArgs<Data, Error, SWRMutationKey, ExtraArg>
   /**
    * Function to reset the mutation state (`data`, `error`, and `isMutating`).

diff --git a/test/type/mutator.ts → test/type/mutate.ts b/test/type/mutator.ts → test/type/mutate.ts
diff --git a/test/type/mutation.ts b/test/type/mutation.ts
@@ -0,0 +1,8 @@
+import useSWRMutation from 'swr/mutation'
+import { expectType } from './utils'
+import type { TriggerWithoutArgs } from '../../mutation/src/types'
+
+export function useConfigMutation() {
+  const { trigger } = useSWRMutation('key', k => k)
+  expectType<TriggerWithoutArgs<'key', any, string, never>>(trigger)
+}