Revert "Feature: make return state(data, error and isValidating) read…

…only" (#1443) * Revert "make return state(data, error and isValidating) readonly (#1431)" This reverts commit ec778e7. * enable diagnostics on CI
vercel · Sep 9, 2021 · e789a4d · e789a4d
1 parent 25a3904
commit e789a4d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -12,7 +12,7 @@ module.exports = {
   globals: {
     'ts-jest': {
       tsconfig: 'test/tsconfig.json',
-      diagnostics: false,
+      diagnostics: process.env.CI,
     }
   },
 }
diff --git a/src/types.ts b/src/types.ts
@@ -148,10 +148,10 @@ export type SWRConfiguration<
 export type Key = ValueKey | (() => ValueKey)
 
 export interface SWRResponse<Data, Error> {
-  data?: Readonly<Data>
-  error?: Readonly<Error>
+  data?: Data
+  error?: Error
   mutate: KeyedMutator<Data>
-  isValidating: Readonly<boolean>
+  isValidating: boolean
 }
 
 export type KeyLoader<Data = any> =

diff --git a/test/use-swr-immutable.test.tsx b/test/use-swr-immutable.test.tsx
@@ -140,10 +140,7 @@ describe('useSWR - immutable', () => {
   })
 
   it('should not revalidate with revalidateIfStale disabled when key changes', async () => {
-    const fetcher = jest.fn(v => {
-      console.log(v)
-      return v
-    })
+    const fetcher = jest.fn(v => v)
 
     const key = createKey()
     const useData = (id: string) =>