Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update key cause infinity render with suspense mode #1836

Closed
eolme opened this issue Feb 3, 2022 · 0 comments · Fixed by #1843
Closed

Update key cause infinity render with suspense mode #1836

eolme opened this issue Feb 3, 2022 · 0 comments · Fixed by #1843

Comments

@eolme
Copy link

eolme commented Feb 3, 2022

Bug report

Description / Observed Behavior

2022-02-03.16.55.29.mov

Repro Steps / Code Example

https://codesandbox.io/s/swr-suspense-infinite-render-0rkuq?file=/src/index.js

Additional Context

swr 1.2.1
react 18

Thanks to @land47 for the original repro.
promer94 added a commit to promer94/swr that referenced this issue Feb 6, 2022
@promer94
add fail test for vercel#1836
3b01d69
@promer94 promer94 mentioned this issue Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset stale unmountedRef in suspense promer94/swr
1 participant
@eolme