Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder exports conditions #2130

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Reorder exports conditions #2130

merged 1 commit into from
Aug 22, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 22, 2022

Reference

According to exports sugar usage

"types" - can be used by typing systems to resolve the typing file for the given export. This condition should always be included first.
Within the "exports" object, key order is significant. During condition matching, earlier entries have higher priority and take precedence over later entries. The general rule is that conditions should be from most specific to least specific in object order.

Changes

This PR adjust the type exports to the top matched conditions to fit usage with typing

@huozhi huozhi requested a review from shuding as a code owner August 22, 2022 21:41
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6722a1c:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding shuding merged commit 7f8312e into main Aug 22, 2022
@shuding shuding deleted the reorder-exports-condition branch August 22, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants