Update build target to es2018 #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c9c578:
|
koba04
approved these changes
Nov 24, 2022
huozhi
approved these changes
Nov 25, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most use cases of SWR, users either have a modern browser (e.g. using modules in the browser + CDN), or have a bundler (esbuild, Webpack). If you still need to target old browsers, it's easy to target a lower version with the bundler.
This change makes sense for the 2.0 version. For the majority this improves the performance of SWR by a lot. According to #2095, the new bundle size will be ~80% of the
es5target. And measured by the SSR benchmark, switching fromObject.assignto the native spread operator makes SSR 4.7x faster (P50) in Node.js 16. This scales linearly with the app size, because eachuseSWR()call contains around 3Object.assignoperations.