New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types properites in exports fields #2341

Merged

shuding merged 1 commit into vercel:main from koba04:fix-types-properties-in-exports

Dec 27, 2022

Collaborator

koba04 commented Dec 27, 2022

fixes #2308

This fixes the path for the properties of the type in package.json.

Each types of package.json are pointed correctly.


          fix: types properites in exports fields

065299a

koba04 requested review from shuding and huozhi as code owners

December 27, 2022 08:15

codesandbox-ci bot commented Dec 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 065299a:

Sandbox	Source
SWR-Basic	Configuration
SWR-States	Configuration
SWR-Infinite	Configuration
SWR-SSR	Configuration

shuding approved these changes

View reviewed changes

shuding merged commit 06a6441 into vercel:main

Member

shuding commented Dec 27, 2022

Thanks!

koba04 deleted the fix-types-properties-in-exports branch

December 27, 2022 09:44

Member

huozhi commented Dec 27, 2022

We can also remove the extra path in each folder name.

We had immutable/dist/immutable/index.d.ts because previously bunchee has some limitations for types generation, and now we can keep it simple types: ./dist/index.d.ts in each package

talzion12 commented Jan 16, 2023

Can the fixed version be published in npm? I don't think it's possible to use swr in typescript with esm without this fix.

koba04 mentioned this pull request

ci: add publint to check packaging on CI #2363

Merged

Member

huozhi commented Jan 18, 2023

@talzion12 the change is released in 2.0.1 🙏

renovate bot mentioned this pull request

Update all non-major dependencies for frontend morning-night-guild/platform#235

Merged

1 task

renovate bot referenced this pull request in Unleash/unleash


          chore(deps): update dependency swr to v2.0.3 (#3091)

346537b

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [swr](https://swr.vercel.app)
([source](https://github.com/vercel/swr)) | [`2.0.0` ->
`2.0.3`](https://renovatebot.com/diffs/npm/swr/2.0.0/2.0.3) |
[![age](https://badges.renovateapi.com/packages/npm/swr/2.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/swr/2.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/swr/2.0.3/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/swr/2.0.3/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/swr</summary>

### [`v2.0.3`](https://github.com/vercel/swr/releases/tag/v2.0.3)

[Compare
Source](https://github.com/vercel/swr/compare/v2.0.2...v2.0.3)

#### Patches

- fix: parameters passed to subscribe is inconsistent with its
declaration by [@&#8203;hong24](https://github.com/hong24) in
[https://github.com/vercel/swr/pull/2353](https://github.com/vercel/swr/pull/2353)
- fix: when inifinite key changes, should use cached pagesize instead of
initialSize by [@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2386](https://github.com/vercel/swr/pull/2386)
- fix: make compare function only compare data
([#&#8203;2375](https://github.com/vercel/swr/issues/2375)) by
[@&#8203;Retrospection](https://github.com/Retrospection) and
[@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2387](https://github.com/vercel/swr/pull/2387)
[https://github.com/vercel/swr/pull/2389](https://github.com/vercel/swr/pull/2389)
- fix: initial loading state should be false with revalidation is
disabed by [@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2382](https://github.com/vercel/swr/pull/2382)
- fix: Ensure hydration matches the SSR result during streaming by
[@&#8203;shuding](https://github.com/shuding) in
[https://github.com/vercel/swr/pull/2391](https://github.com/vercel/swr/pull/2391)

#### Chores

- ci: only run release when tags pushed by
[@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2388](https://github.com/vercel/swr/pull/2388)
- unify `-` characters in README.md by
[@&#8203;JanKaifer](https://github.com/JanKaifer) in
[https://github.com/vercel/swr/pull/2334](https://github.com/vercel/swr/pull/2334)

#### New Contributors

- [@&#8203;hong24](https://github.com/hong24) made their first
contribution in
[https://github.com/vercel/swr/pull/2353](https://github.com/vercel/swr/pull/2353)
- [@&#8203;Retrospection](https://github.com/Retrospection) made their
first contribution in
[https://github.com/vercel/swr/pull/2387](https://github.com/vercel/swr/pull/2387)
- [@&#8203;JanKaifer](https://github.com/JanKaifer) made their first
contribution in
[https://github.com/vercel/swr/pull/2334](https://github.com/vercel/swr/pull/2334)

**Full Changelog**:
vercel/swr@v2.0.2...v2.0.3

### [`v2.0.2`](https://github.com/vercel/swr/releases/tag/v2.0.2)

[Compare
Source](https://github.com/vercel/swr/compare/v2.0.1...v2.0.2)

#### Patches

- fix: delay revalidation if a key is already active and has error by
[@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2338](https://github.com/vercel/swr/pull/2338)
- fix: createCacheHelper type by
[@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2365](https://github.com/vercel/swr/pull/2365)

#### Chores

- release workflow by [@&#8203;huozhi](https://github.com/huozhi) in
[https://github.com/vercel/swr/pull/2374](https://github.com/vercel/swr/pull/2374),
[https://github.com/vercel/swr/pull/2381](https://github.com/vercel/swr/pull/2381),
[https://github.com/vercel/swr/pull/2383](https://github.com/vercel/swr/pull/2383),
[https://github.com/vercel/swr/pull/2384](https://github.com/vercel/swr/pull/2384),
[https://github.com/vercel/swr/pull/2385](https://github.com/vercel/swr/pull/2385)

**Full Changelog**:
vercel/swr@v2.0.1...v2.0.2

### [`v2.0.1`](https://github.com/vercel/swr/releases/tag/v2.0.1)

[Compare Source](https://github.com/vercel/swr/compare/2.0.0...v2.0.1)

In this patch release, we majorly improved typing support and SWR can
infer the types based on the configuration.

- When the `suspense` option is `true`, the returned `data` will exclude
`undefined` and the `isLoading` will always be `false`.
- When the `fallbackData` option is provided, the returned `data` will
be the same type of `fallbackData`, and the `isLoading` will always be
`false`.

Here's a demo for it:


https://user-images.githubusercontent.com/4800338/213288879-ffbeeeb5-aca5-4a65-8229-69fbf9b0bf70.mp4

#### What's Changed

- types: make FullConfiguration generic by
[@&#8203;huozhi](https://github.com/huozhi) in
[https://github.com/vercel/swr/pull/2273](https://github.com/vercel/swr/pull/2273)
- type: enforce array literal as tuple by
[@&#8203;promer94](https://github.com/promer94) in
[https://github.com/vercel/swr/pull/2283](https://github.com/vercel/swr/pull/2283)
- Improve type test by [@&#8203;promer94](https://github.com/promer94)
in
[https://github.com/vercel/swr/pull/2289](https://github.com/vercel/swr/pull/2289)
- update bunchee to remove the extra target cli option by
[@&#8203;huozhi](https://github.com/huozhi) in
[https://github.com/vercel/swr/pull/2298](https://github.com/vercel/swr/pull/2298)
- fix: useSWRMutation should always use the latest fetcher by
[@&#8203;koba04](https://github.com/koba04) in
[https://github.com/vercel/swr/pull/2290](https://github.com/vercel/swr/pull/2290)
- types: conditional swr response by
[@&#8203;huozhi](https://github.com/huozhi) in
[https://github.com/vercel/swr/pull/2301](https://github.com/vercel/swr/pull/2301)
- fix: types properites in exports fields by
[@&#8203;koba04](https://github.com/koba04) in
[https://github.com/vercel/swr/pull/2341](https://github.com/vercel/swr/pull/2341)
- Update license year by
[@&#8203;IcedMonk](https://github.com/IcedMonk) in
[https://github.com/vercel/swr/pull/2344](https://github.com/vercel/swr/pull/2344)
- feat: add all mutate options support to useSWRInfinite by
[@&#8203;koba04](https://github.com/koba04) in
[https://github.com/vercel/swr/pull/2350](https://github.com/vercel/swr/pull/2350)
- ci: add publint to check packaging on CI by
[@&#8203;koba04](https://github.com/koba04) in
[https://github.com/vercel/swr/pull/2363](https://github.com/vercel/swr/pull/2363)

#### New Contributors

- [@&#8203;IcedMonk](https://github.com/IcedMonk) made their first
contribution in
[https://github.com/vercel/swr/pull/2344](https://github.com/vercel/swr/pull/2344)

**Full Changelog**: vercel/swr@2.0.0...v2.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet