-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure hydration matches the SSR result during streaming #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e794b81:
|
promer94
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diagram and explanation are awesome !
promer94
reviewed
Jan 27, 2023
huozhi
approved these changes
Jan 28, 2023
Merged
renovate bot
referenced
this pull request
in Unleash/unleash
Feb 12, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://github.com/vercel/swr)) | [`2.0.0` -> `2.0.3`](https://renovatebot.com/diffs/npm/swr/2.0.0/2.0.3) | [![age](https://badges.renovateapi.com/packages/npm/swr/2.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/swr/2.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/swr/2.0.3/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/swr/2.0.3/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.0.3`](https://github.com/vercel/swr/releases/tag/v2.0.3) [Compare Source](https://github.com/vercel/swr/compare/v2.0.2...v2.0.3) #### Patches - fix: parameters passed to subscribe is inconsistent with its declaration by [@​hong24](https://github.com/hong24) in [https://github.com/vercel/swr/pull/2353](https://github.com/vercel/swr/pull/2353) - fix: when inifinite key changes, should use cached pagesize instead of initialSize by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2386](https://github.com/vercel/swr/pull/2386) - fix: make compare function only compare data ([#​2375](https://github.com/vercel/swr/issues/2375)) by [@​Retrospection](https://github.com/Retrospection) and [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2387](https://github.com/vercel/swr/pull/2387) [https://github.com/vercel/swr/pull/2389](https://github.com/vercel/swr/pull/2389) - fix: initial loading state should be false with revalidation is disabed by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2382](https://github.com/vercel/swr/pull/2382) - fix: Ensure hydration matches the SSR result during streaming by [@​shuding](https://github.com/shuding) in [https://github.com/vercel/swr/pull/2391](https://github.com/vercel/swr/pull/2391) #### Chores - ci: only run release when tags pushed by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2388](https://github.com/vercel/swr/pull/2388) - unify `-` characters in README.md by [@​JanKaifer](https://github.com/JanKaifer) in [https://github.com/vercel/swr/pull/2334](https://github.com/vercel/swr/pull/2334) #### New Contributors - [@​hong24](https://github.com/hong24) made their first contribution in [https://github.com/vercel/swr/pull/2353](https://github.com/vercel/swr/pull/2353) - [@​Retrospection](https://github.com/Retrospection) made their first contribution in [https://github.com/vercel/swr/pull/2387](https://github.com/vercel/swr/pull/2387) - [@​JanKaifer](https://github.com/JanKaifer) made their first contribution in [https://github.com/vercel/swr/pull/2334](https://github.com/vercel/swr/pull/2334) **Full Changelog**: vercel/swr@v2.0.2...v2.0.3 ### [`v2.0.2`](https://github.com/vercel/swr/releases/tag/v2.0.2) [Compare Source](https://github.com/vercel/swr/compare/v2.0.1...v2.0.2) #### Patches - fix: delay revalidation if a key is already active and has error by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2338](https://github.com/vercel/swr/pull/2338) - fix: createCacheHelper type by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2365](https://github.com/vercel/swr/pull/2365) #### Chores - release workflow by [@​huozhi](https://github.com/huozhi) in [https://github.com/vercel/swr/pull/2374](https://github.com/vercel/swr/pull/2374), [https://github.com/vercel/swr/pull/2381](https://github.com/vercel/swr/pull/2381), [https://github.com/vercel/swr/pull/2383](https://github.com/vercel/swr/pull/2383), [https://github.com/vercel/swr/pull/2384](https://github.com/vercel/swr/pull/2384), [https://github.com/vercel/swr/pull/2385](https://github.com/vercel/swr/pull/2385) **Full Changelog**: vercel/swr@v2.0.1...v2.0.2 ### [`v2.0.1`](https://github.com/vercel/swr/releases/tag/v2.0.1) [Compare Source](https://github.com/vercel/swr/compare/2.0.0...v2.0.1) In this patch release, we majorly improved typing support and SWR can infer the types based on the configuration. - When the `suspense` option is `true`, the returned `data` will exclude `undefined` and the `isLoading` will always be `false`. - When the `fallbackData` option is provided, the returned `data` will be the same type of `fallbackData`, and the `isLoading` will always be `false`. Here's a demo for it: https://user-images.githubusercontent.com/4800338/213288879-ffbeeeb5-aca5-4a65-8229-69fbf9b0bf70.mp4 #### What's Changed - types: make FullConfiguration generic by [@​huozhi](https://github.com/huozhi) in [https://github.com/vercel/swr/pull/2273](https://github.com/vercel/swr/pull/2273) - type: enforce array literal as tuple by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2283](https://github.com/vercel/swr/pull/2283) - Improve type test by [@​promer94](https://github.com/promer94) in [https://github.com/vercel/swr/pull/2289](https://github.com/vercel/swr/pull/2289) - update bunchee to remove the extra target cli option by [@​huozhi](https://github.com/huozhi) in [https://github.com/vercel/swr/pull/2298](https://github.com/vercel/swr/pull/2298) - fix: useSWRMutation should always use the latest fetcher by [@​koba04](https://github.com/koba04) in [https://github.com/vercel/swr/pull/2290](https://github.com/vercel/swr/pull/2290) - types: conditional swr response by [@​huozhi](https://github.com/huozhi) in [https://github.com/vercel/swr/pull/2301](https://github.com/vercel/swr/pull/2301) - fix: types properites in exports fields by [@​koba04](https://github.com/koba04) in [https://github.com/vercel/swr/pull/2341](https://github.com/vercel/swr/pull/2341) - Update license year by [@​IcedMonk](https://github.com/IcedMonk) in [https://github.com/vercel/swr/pull/2344](https://github.com/vercel/swr/pull/2344) - feat: add all mutate options support to useSWRInfinite by [@​koba04](https://github.com/koba04) in [https://github.com/vercel/swr/pull/2350](https://github.com/vercel/swr/pull/2350) - ci: add publint to check packaging on CI by [@​koba04](https://github.com/koba04) in [https://github.com/vercel/swr/pull/2363](https://github.com/vercel/swr/pull/2363) #### New Contributors - [@​IcedMonk](https://github.com/IcedMonk) made their first contribution in [https://github.com/vercel/swr/pull/2344](https://github.com/vercel/swr/pull/2344) **Full Changelog**: vercel/swr@2.0.0...v2.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
promer94
added a commit
to promer94/swr
that referenced
this pull request
Mar 4, 2023
…uring streaming close vercel#2473 x-ref vercel#2391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Here's a diagram explaining the problem:
First, In SSR, the
data
will always beundefined
for anyuseSWR
hook, becauseuseEffect
never runs during SSR. Same for streaming SSR because it's still SSR, but with some components being delayed a bit.So, to make sure client hydration matches the SSR result, all
useSWR
hooks should returnundefined
during their hydration render. That's easy when we hydrate all things together, because the cache is always empty initially, and the hydration process will finish before any data fetching happens.However, with streaming SSR React can partially hydrate a part of the app. In the example above, the first
useSWR
hook was hydrated first, and the second is still pending due to slow network or a suspense boundary. After the hydration of the firstuseSWR
hook, it fetches the data and updates the global cache on the client. And then, the second one hydrates. During its hydration render, it already reads the updated cache, instead ofundefined
. This causes a hydration mismatch.The fix is to pass a server snapshot to
useSyncExternalStore
, so React will use that snapshot during hydration renders. And all we need to do is to make sure that we store the initial cache value somewhere before any write happens on the client, and return that initial cache as the server snapshot.Reproduction
It's very tricky to reproduce and test this problem in our Jest setup. So I made this Sandbox to test: https://codesandbox.io/p/sandbox/swr-ssr-forked-tlgw5b?file=%2Fapp%2Fpage.js
Hydration mismatch in current
swr@latest
:Works fine with this fix: