Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify ci config and bump some deps version #2770

Merged
merged 2 commits into from
Dec 7, 2024
Merged

ci: simplify ci config and bump some deps version #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9685d24
simplify ci
promer94 Sep 5, 2023
0d58fc4
revert lock
huozhi Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/trigger-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,12 @@ on:
name: Trigger Release

env:
PNPM_VERSION: 8.4.0
Copy link
Collaborator Author

@promer94 promer94 Dec 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm/set-up will read version from package.json

SEMVER_TYPE: ${{ github.event.inputs.semverType }}
RELEASE_TYPE: ${{ github.event.inputs.releaseType }}

jobs:
start:
runs-on: ubuntu-latest

environment: release-${{ github.event.inputs.releaseType }}-${{ github.event.inputs.semverType }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we dont have multiple enviornments now, so this could be removed

steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -37,7 +34,9 @@ jobs:
token: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }}
- name: Install
uses: ./.github/workflows/install
- run: |
- name: Test
run: |
pnpm run-all-checks
pnpm clean
pnpm build
pnpm run-all-checks
Expand All @@ -53,11 +52,6 @@ jobs:
node ./scripts/bump-next-version.js

- name: Git push
env:
RELEASE_BOT_GITHUB_TOKEN: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think git never use this env

run: |
git push origin main
git push origin --tags



2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"devDependencies": {
"@edge-runtime/jest-environment": "^3.0.4",
"@arethetypeswrong/cli": "^0.15.3",
"@playwright/test": "^1.34.3",
"@playwright/test": "1.34.3",
"@swc/core": "^1.3.62",
"@swc/jest": "0.2.26",
"@testing-library/jest-dom": "^5.16.5",
Expand Down
3 changes: 2 additions & 1 deletion pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading